Skip to content

fix(pip): lowest meter on collapse, named per-model rows last, percent on the right, scrollable overflow - #341

Merged
jaywedgeworth22 merged 2 commits into
mainfrom
fix/pip-quota-popup-ux
Oct 30, 2026
Merged

jaywedgeworth22 merged 2 commits into
mainfrom
fix/pip-quota-popup-ux

Conversation

@jaywedgeworth22

@jaywedgeworth22 jaywedgeworth22 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Fixes PiP quota popup to show the most constrained limit first and keep per-model limits identifiable.

What changed:

  • Collapsed rows keep the lowest meter: When a row only has room for one meter, it now keeps the window with the least remaining percent instead of whichever came first. Meters with unknown percentage rank last. Order is otherwise preserved.
  • Platform windows first, per-model windows last: Expanded platform detail now orders primary windows (e.g. 5-hour, 7-day / Gemini Models) before per-model sub-limits (e.g. Fable, Argon).
  • Per-model rows are always named: Detail rows show the model name for sub-model windows, derived from a "<model> · <cadence>" label or fallback to the recorded model id/type. Primary windows and OpenAI scoped pools are unchanged.
  • Percent moved to the right of the bar: Expanded detail row layout is now caption, optional model name, bar, then percent and countdown, matching other surfaces. Percent uses a fixed width for alignment.
  • Scrollable pinned overflow: All pinned rows are now inside the scroll view. Scroll indicators show only when content overflows, and the "N more pinned — scroll" hint sits below the scroll view so it never scrolls away.

Adds QuotaWindowPresentation ordering/collapsing helpers in QuotaCore with QuotaWindowPresentationTests coverage.

…t after bar, scrollable overflow

Owner report 2026-10-30.  A row collapsed to one meter now keeps the window
with the least remaining.  The platform detail lists the platform's own
windows before its per-model windows and names each per-model window by
the model the reading carries (Fable, Gemini 4 Argon).  The percentage sits
after the bar as on every other surface.  The rows panel now puts every
pinned row in its scroll view, so the overflow hint is reachable.
@kody-ai

kody-ai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

​

@jaywedgeworth22

Copy link
Copy Markdown
Member Author

@kody start-review

Comment thread Sources/CodeCaps/PipWidget.swift Resolved
…eep reader casing

Review findings on #341: the hint under the scroll view reduced the rows'
height without the count knowing, and capitalized lower-cased acronym
model ids.
@jaywedgeworth22
jaywedgeworth22 enabled auto-merge (squash) October 30, 2026 05:42
@jaywedgeworth22
jaywedgeworth22 merged commit b933014 into main Oct 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant