Skip to content

feat(worker): creator-controlled team-only bot sharing - #157

Merged
swu-wise[bot] merged 4 commits into
mainfrom
wise/creator-bot-team-only
Nov 1, 2026
Merged

swu-wise[bot] merged 4 commits into
mainfrom
wise/creator-bot-team-only

Conversation

@jaywedgeworth22

@jaywedgeworth22 jaywedgeworth22 commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Change

Creator-level bot team-only sharing setting, default ON for existing and new accounts per Jay's latest rollout answer. Each main account can opt out. Existing shares retain their current visibility; there is no automatic resharing.

Bots with policy on cannot create personal files/links, move shares personal, or write files/link destinations into existing personal shares through REST/raw/CLI/MCP. Missing/inactive manager policy fails closed on affected writes without forcing visibility wider. People retain management rights; team-visible writes and reads are unaffected. Atomic authorized move-to-team plus link edit uses effective post-move visibility.

Validation

206 tests PASS, npm run bundle PASS, git diff --check clean, independently repeated after each focused patch. Live main base d70bf53. Current head 6b7c6cf.

Review and rollout

Prior HIGH findings fixed with evidence replies/resolutions. MEDIUM atomic move/edit finding fixed in current head. Current full functional composition requires genuine review and CI qualification before merge/deploy. Production remains unchanged; deploy owner must ground actual Jay identity/live creator policy. Focused FleetLink worker owns remaining findings/CI/outcome.

Summary

Enables creator-controlled team-only sharing for bots, turned on by default for every account.

When a manager leaves the bot setting on (the default for existing and new accounts unless turned off):

  • A bot's new files and links always land in a team; personal requests are refused.
  • A bot cannot write files or links into a personal share until its manager moves that share to a team.
  • Only the manager can move one of its bot's shares to personal.
  • Existing shares keep their current visibility until the owner moves them — no retroactive resharing.

Changes

  • Changed the bot_team_only default so it applies to all accounts, existing and new, with per-account opt-out in bot settings instead of limiting team-only to the fleet owner.
  • Fixed share updates so an atomic move-to-team plus content edit in one request is evaluated against the post-move team and succeeds.
  • Updated multi-user documentation to describe the default-on policy, the write block on personal shares, and grandfathering of existing shares.
  • Updated migration and fleet-bot tests to cover the new default and the atomic move-to-team edit case.

@kody-ai

This comment has been minimized.

@swu-wise

swu-wise Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

@kody start-review
Please review the whole 11-file creator-controlled bot team-only sharing change at d505d27, especially migration v11 preservation of existing non-owner managers, shared REST/raw/MCP enforcement, account setting, and UI. Independent validation: 204 tests PASS and npm run bundle PASS. No merge/deploy yet; focused FleetLink worker owns findings/CI follow-through.

Comment thread worker/lib/shares.mjs Resolved
Comment thread worker/lib/shares.mjs Resolved
@swu-wise

swu-wise Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

@kody start-review
Please review the current whole functional composition at31c26cfc0d7986bd6526d036f3a638286f43cbca (12 files versus main), including newly added creator-policy resolution/enforcement paths. Prior round completed with bothHIGHfindings fixed and evidence replies4433812673/4433813006; boththreadsresolved. Missing/inactive manager now refuses creates/team moves without forced disclosure; existing personal file/link writes now refuse through shared write funnel before mutation.206tests/npm bundlePASS. Automatic currenthead Kody check wasSKIPPED, so requesting this functional-composition review once. No merge/deploy yet.

@kody-ai

This comment has been minimized.

Comment thread worker/lib/shares.mjs Resolved
@swu-wise

swu-wise Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

@kody start-review
Current whole functional composition at6b7c6cf9b55c85a9bad928acd2c1de8eefdd09d9 needs review after actual rollout decision: creator bot-team-only defaultON for existing and new accounts (no retroactive share visibility changes). Prior whole round complete, MEDIUM4433826591 now fixed with effective post-move link visibility and regression; evidence4433855860. All3knownfindingsresolved,206tests/npm bundlePASS. Currenthead automaticKodycheckSKIPPED. Please review migration default-on scope and cumulative creator-policy/write enforcement paths. One request for this stable composition; no merge/deploy yet.

@kody-ai

kody-ai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

​

@swu-wise
swu-wise Bot merged commit 120f3f3 into main Nov 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant