refactor(stripe): use lookup keys instead of hardcoded price IDs - #28
Conversation
- Replace NEXT_PUBLIC_STRIPE_PRO_*_PRICE_ID env vars with Stripe lookup keys - Add convex/lib/stripeHelpers.ts with price resolution logic - Add 27 unit tests for stripe helpers - Fix TypeScript strict mode violations (any -> unknown) - Delete obsolete lib/config/stripe.ts Stripe Dashboard is now the single source of truth for pricing. Set lookup_key: pro_monthly on the price in Stripe Dashboard.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis refactoring shifts Stripe price management from static environment-based configuration to runtime lookup-key resolution. The system now uses planType to dynamically resolve prices via new Stripe helpers, eliminating pre-check validation and simplifying the checkout flow. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Stripe Dashboard is now the single source of truth for pricing. Set lookup_key: pro_monthly on the price in Stripe Dashboard.
Summary by CodeRabbit
Tests
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.