Fix mobile lightbox freeze after closing from the history drawer - #36
Closed
CanyoufeeltheAGI with Copilot wants to merge 2 commits into
Closed
CanyoufeeltheAGI with Copilot wants to merge 2 commits into
CanyoufeeltheAGI with Copilot wants to merge 2 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-authored-by: CanyoufeeltheAGI <255605710+CanyoufeeltheAGI@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failures in history drawer lightbox
Fix mobile lightbox freeze after closing from the history drawer
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile, opening the lightbox from the history drawer could leave the page non-interactive after close. The underlying issue was overlapping drawer/dialog teardown, which could strand
pointer-events,aria-hidden, orinerton body-level nodes.Serialize mobile modal transitions
openLightboxnow closes any mobile drawer first and defers the lightbox open until the drawer close animation has finished.Harden lightbox close cleanup
closeLightboxnow performs delayed cleanup after dialog teardown instead of usingrequestAnimationFrame.pointer-eventsonbodyand removes lingeringaria-hidden/inertattributes when no other modal is open.Keep callback behavior stable without render-time ref mutation
openLightboxis still read through a ref to avoid callback churn, but the ref is now synchronized inuseLayoutEffectinstead of during render.Add regression coverage
pointer-eventsAlign CI inputs
bun.lockis updated for the added@testing-library/domdependency so frozen lockfile installs match the checked-in dependency graph.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.