adding --paint only option for all a) b) and c) - #17
Open
jafranc wants to merge 6 commits into
Open
Conversation
Contributor
|
This is still marked as a draft. What's the current status? |
* adding pore-volume multipliers on a VOLUME fields instead of directly PORO, porosity fields
jafranc
marked this pull request as ready for review
October 16, 2023 16:48
Contributor
Author
I think it is ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces few fixes and improvement to 'extrude_and_rotate.py', as follows :
As for spe11-c, the generated mesh is already 3D, '--paint' is the only valid option.
--poromultporevolume accessed pore-volume multipliers acting on a VOLUME celldata array rather than on the PORO celldata array that contains porosity. It avoids crash of formula splitting fluid phase from solid using weighting of the form(1-PORO[i])andPORO[i]Note: for spe11-c, this only paint inherited permeability tensors from spe11-b and not the rotated version obtained from Eq. (4.4), as it can be introduced or obtained as a post-processing of the read values
Note: in the case of painted 2D meshes, the gmsh generated vtk meshes introduces VTKLINE elements that count as cells. On these cells, the permeability, porosity and attribute (region tag) are set to -1.