Skip to content

Finish rocrate - #2

Open
M-Jafarkhani wants to merge 31 commits into
mainfrom
finish_rocrate
Open

Finish rocrate#2
M-Jafarkhani wants to merge 31 commits into
mainfrom
finish_rocrate

Conversation

@M-Jafarkhani

Copy link
Copy Markdown
Collaborator

This PR integrates RoCrate and Rohub into rotating-cylinders benchmark, the same implementation as linear-elastic-plate-with-hole, closing #1

@joergfunger joergfunger left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it make sense to wait until we have the package being integrated into the plate benchmark? We would now have to adapt the changes that are made there then here once again. (I'm also on holiday and do not have the time to look at the RR in detail).

@M-Jafarkhani

Copy link
Copy Markdown
Collaborator Author

I am also working on the semantic package, which could be ready to use next week. I also agree that we can merge two PRs into one (RoHub/RoCrate + Semantic Package)

@M-Jafarkhani

M-Jafarkhani commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator Author

This pull request introduces additional changes:

1. Split benchmark workflows

The workflows used for branch protection have been separated into three independent, tool-specific workflows:

  • .github/workflows/run-benchmark-dumux.yml
  • .github/workflows/run-benchmark-openfoam.yml

Although these workflows are largely similar, each is dedicated to a single simulation tool. They execute the benchmark independently and do not interact with RoHub.

2. Dedicated RoHub integration workflow

A new workflow, .github/workflows/rohub-integration.yml, has been introduced to test the RoHub integration. It performs the following steps:

  1. Downloads the benchmark data from RoHub.
  2. Invokes the tool-specific benchmark workflows listed above to generate an aggregated RO-Crate.
  3. Uploads the aggregated RO-Crate back to RoHub.

3. Integration of the semantic-benchmark package

This pull request also refactors the shared semantic benchmark functionality into a standalone Python package. The package is now published on the Python Package Index and can be installed with:

pip install semantic-benchmark

This allows the shared functionality to be reused across repositories while keeping the benchmark workflows simpler and easier to maintain.

@Sarbani-Roy

@M-Jafarkhani
M-Jafarkhani requested a review from joergfunger July 12, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants