Review#1
Open
SirDraiger wants to merge 8 commits into
Open
Conversation
kyzinatra
reviewed
Apr 24, 2024
| className={styles.container}> | ||
| <img src={arrow} alt='иконка стрелочки' className={styles.arrow} /> | ||
| className={clsx(styles.container, { [styles.container_open]: isOpen })} | ||
| onClick={onClick}> |
There was a problem hiding this comment.
Отлично! Круто, что вы используете clsx
kyzinatra
reviewed
Apr 24, 2024
| return () => { | ||
| document.removeEventListener('mousedown', handleClick); | ||
| document.removeEventListener('keydown', handlePressEsc); | ||
| }; |
There was a problem hiding this comment.
Отлично! Хорошая реализация форм, круто, что вы очищаете обработчик
kyzinatra
reviewed
Apr 24, 2024
| const App = () => { | ||
| // Текущие параметры статьи. По умолчанию заполняем дефолтными значениями | ||
| const [currentArticleState, setCurrentArticleState] = | ||
| useState(defaultArticleState); |
There was a problem hiding this comment.
Можно лучше: компонент app лучше вынести в отдельную папку
|
Отличная работа! Вы прекрасно потрудились над работой. Хорошая реализация логики кода и отображения. Понравилось, что вы сделали переворот стрелки и закрытие по клику на оверлей. Ваша работа принята! Будет ждать от вас новых pr на следующих спринтах |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.