fix: add missing closing brace for view(resolver:) in Screen.swift#32
Draft
Sjoerd-Bo3 with Copilot wants to merge 29 commits into
Draft
fix: add missing closing brace for view(resolver:) in Screen.swift#32Sjoerd-Bo3 with Copilot wants to merge 29 commits into
Sjoerd-Bo3 with Copilot wants to merge 29 commits into
Conversation
- Add SettingsChangeStored Core Data entity with fetch indexes - Add SettingsChangeStored CoreData class and properties files - Add SettingsAuditStorage protocol and BaseSettingsAuditStorage implementation - Register SettingsAuditStorage in StorageAssembly - Add SettingsMetadataRegistry mapping setting keys to human-readable metadata - Integrate audit logging in BaseSettingsManager for TrioSettings and Preferences changes - Add audit logging to BasalProfileEditor, ISFEditor, CarbRatioEditor, TargetsEditor providers - Add SettingsAuditLog module (DataFlow, Provider, StateModel, RootView) - Add settingsAuditLog screen case to Router - Add 'Settings Change Log' entry point in SettingsRootView Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Use a single DateFormatter for both grouping and sorting to avoid repeated instantiation inside the sort closure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
All DateFormatter instances in SettingsAuditLog views and StateModel are now static properties, created once and reused across calls and rows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…udit log Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/83fd0a12-2bfd-499b-a3d6-7c04a4b43529 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/bc9ab337-4348-4e19-9c72-5532cfb86585 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Sjoerd-Bo3
April 7, 2026 09:20
View session
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/42190838-9695-4873-8f22-2930c04fcc88 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…Phase and fix indentation Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/3ec37fd3-d9a8-454c-a053-287c2b5da009 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…or-based diff Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/3ec37fd3-d9a8-454c-a053-287c2b5da009 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/3ec37fd3-d9a8-454c-a053-287c2b5da009 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…sChangeStored files Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/8e054e2e-c2c5-4e1e-81c1-bd02b42a2f15 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
… and track cgmPluginIdentifier Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/74b2250e-7323-4364-b102-bfa47164b7cf Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/74b2250e-7323-4364-b102-bfa47164b7cf Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…d of Core Data managed objects in UI Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/de91fd5c-b81a-418a-8fd6-cd718d2c177d Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/de91fd5c-b81a-418a-8fd6-cd718d2c177d Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…basal total Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/a962aa11-adf2-4c0c-b304-46964ea50f72 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/a962aa11-adf2-4c0c-b304-46964ea50f72 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/a962aa11-adf2-4c0c-b304-46964ea50f72 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/4987cad5-903b-4ede-8d18-7b8bfe883694 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…ebounceTask on disappear and adding @mainactor to mutation methods Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/76049541-2cf7-4f68-9669-ffce49338803 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
…ror while keeping .onDisappear crash fix Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/ff21c582-932d-42b2-918b-adef0fa9d374 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
- convert core data managed objects to value types atomically inside performAndWait via new fetchChangeEntries method, preventing faulting/invalidation between fetch and property access - add explicit @mainactor isolation to debounce task to prevent concurrent entries array mutation during view teardown - flush pending note save synchronously on disappear instead of just cancelling the debounce task - add Sendable conformance to ChangeEntry for compile-time safety
…ries to audit log Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/059f9b5c-000a-4508-a563-4f71ab4f7082 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/059f9b5c-000a-4508-a563-4f71ab4f7082 Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/2376796f-1de8-4a61-aec6-e19d00bd555c Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
… prevent crash Agent-Logs-Url: https://github.com/Sjoerd-Bo3/Trio/sessions/14755bc8-a3e8-4e17-87a0-9db1229e996e Co-authored-by: Sjoerd-Bo3 <2100083+Sjoerd-Bo3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShareSheetstruct (previous fix).sheetmodifiers into a singlesheet(item:)with anActiveSheetenum to prevent UIActivityViewController/SwiftUI sheet conflictsonDismisscleanup for pending note saves