Restore pump-pill and bolus-card border animations in the new Home#58
Merged
Merged
Conversation
The Liquid-Glass Home kept the loop-pill spinning border but dropped two others: - Pump pill: HomeRootView+Header called PumpView without isBolusing, so the reservoir pill border never animated during a bolus. Pass isBolusing: state.bolusStatus != .noBolus. - Bolus card: the card used a bottom BolusProgressBar instead of the fork's full-card progress border. Replace it with progressRoundedBorder (fill runs left→right along the top and bottom edges as the bolus completes), matching the panel corner radius and the pump/loop pill treatment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Liquid-Glass Home kept the loop-pill spinning border but dropped two of the fork's animations. This restores them:
HomeRootView+Headerwas callingPumpView(...)withoutisBolusing, so the reservoir-pill border never spun during a bolus (even thoughPumpViewstill supports it). Now passesisBolusing: state.bolusStatus != .noBolus, so it animates during both the initiating and delivering phases.BolusProgressBarinstead of the fork's full-card border. Swapped it forprogressRoundedBorder(the bright fill runs left→right along the top and bottom edges as the bolus completes), using the glass panel's corner radius (26) and a 3pt line to match the pump/loop pill treatment.The loop pill already had its spinning border (
LoopView.spinningCapsuleBorder(isActive: showLooping)), so it's untouched.Notes
BolusProgressBaris still used by the Treatments view — only removed from the Home card.isLoopingissue rather than the border).Verification
compile_checkruns on this branch.Generated by Claude Code