Skip to content

Audit and tighten top-level public API exports (config + IO convenience aliases)#1306

Merged
SkBlaz merged 4 commits intomasterfrom
copilot/audit-py3plex-public-api
Mar 29, 2026
Merged

Audit and tighten top-level public API exports (config + IO convenience aliases)#1306
SkBlaz merged 4 commits intomasterfrom
copilot/audit-py3plex-public-api

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 28, 2026

  • Investigate failing CI workflow/job logs for branch and identify root cause
  • Apply minimal backward-compatible fix for Python 3.8 import regression introduced by top-level API exports
  • Adjust focused tests to validate new behavior without eager-import side effects
  • Run targeted tests reproducing the failing path and updated API export checks
  • Run code review and security scan, then reply on PR comment with commit hash

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI linked an issue Mar 28, 2026 that may be closed by this pull request
Copilot AI and others added 2 commits March 28, 2026 07:33
Copilot AI changed the title [WIP] Audit py3plex public API for inconsistencies and propose cleanup plan Audit and tighten top-level public API exports (config + IO convenience aliases) Mar 28, 2026
Copilot AI requested a review from SkBlaz March 28, 2026 07:35
@SkBlaz
Copy link
Copy Markdown
Owner

SkBlaz commented Mar 28, 2026

@copilot tests fail

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 28, 2026

@copilot tests fail

Fixed in commit dfaf0d6.

I traced the failing CI run (validate-quickstart (3.8)) to eager top-level py3plex.io imports added in py3plex/__init__.py, which triggered a Python 3.8 type-annotation evaluation error during import. I replaced those eager imports with lazy top-level wrapper aliases (save_to_arrow, load_from_arrow, save_network_to_parquet, load_network_from_parquet) so the API remains available without import-time regression.

Targeted tests were re-run after the change:

  • python3 -m pytest tests/test_public_api_exports.py -q
  • python3 -m pytest tests/test_config_api.py -q

@SkBlaz SkBlaz marked this pull request as ready for review March 29, 2026 06:29
@SkBlaz SkBlaz merged commit ecf6081 into master Mar 29, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api

2 participants