Skip to content

Add 10 high-value missing tests across DSL v2, temporal, uncertainty, and plugin contracts#1308

Merged
SkBlaz merged 2 commits intomasterfrom
copilot/identify-high-value-missing-tests
Mar 28, 2026
Merged

Add 10 high-value missing tests across DSL v2, temporal, uncertainty, and plugin contracts#1308
SkBlaz merged 2 commits intomasterfrom
copilot/identify-high-value-missing-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 28, 2026

The issue requested a targeted review of the suite and addition of the highest-value missing tests in DSL v2, temporal behavior, uncertainty handling, and plugins, without adding markdown docs.
This PR adds 10 focused regression/contract tests in existing test modules to close high-risk gaps around error contracts, algebra semantics, temporal edge cases, and UQ/provenance behavior.

  • DSL v2: error and algebra contracts

    • Added coverage for parameter-binding error quality (ParameterMissingError includes provided parameter context).
    • Added post-execution algebra tests for multilayer result union:
      • ambiguous identity strategy path,
      • mixed deterministic/UQ conflict path,
      • explicit conflict resolution success path.
  • Temporal DSL and temporal utilities

    • Added execution-time guard coverage for unsupported window aggregation modes.
    • Added AST-level coverage for negative timestamp temporal windows.
    • Added partial-interval edge-case coverage in temporal extraction (t_start + invalid t_end => unbounded end).
  • Uncertainty: defaults and edge-case payloads

    • Added test validating metric-level uncertainty method/sample settings override global defaults.
    • Added edge-case test ensuring small-network UQ outputs remain structured (mean/std/method/sample metadata present).
  • Plugins: registry and temporal contract behavior

    • Added test ensuring validation-failing plugins remain discoverable in registry listings but are not retrievable.
    • Added plugin contract test for temporal network input rejection path (graceful domain error).
  • Provenance replay + uncertainty

    • Added replay coverage for UQ-computed metrics to ensure payload/schema and UQ config metadata are preserved across replay.

Example of the new high-value contract coverage:

r1 = Q.nodes().compute("degree").execute(net)
r2 = Q.nodes().compute("degree", uncertainty=True, method="bootstrap", n_samples=5).execute(net)

r1.meta["identity_strategy"] = "by_replica"
r2.meta["identity_strategy"] = "by_replica"

with pytest.raises(AttributeConflictError):
    _ = r1 | r2

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI linked an issue Mar 28, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Identify 10 highest-value missing tests for DSL v2 Add 10 high-value missing tests across DSL v2, temporal, uncertainty, and plugin contracts Mar 28, 2026
Copilot AI requested a review from SkBlaz March 28, 2026 07:46
@SkBlaz SkBlaz marked this pull request as ready for review March 28, 2026 10:10
@SkBlaz SkBlaz merged commit d35f92e into master Mar 28, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests

2 participants