Make QueryBuilder.explain_plan() effective and one-shot at execution time#1319
Merged
Make QueryBuilder.explain_plan() effective and one-shot at execution time#1319
QueryBuilder.explain_plan() effective and one-shot at execution time#1319Conversation
Agent-Logs-Url: https://github.com/SkBlaz/py3plex/sessions/10390147-c8b1-46f7-b37a-3d2920494533 Co-authored-by: SkBlaz <10035780+SkBlaz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/SkBlaz/py3plex/sessions/10390147-c8b1-46f7-b37a-3d2920494533 Co-authored-by: SkBlaz <10035780+SkBlaz@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
SkBlaz
March 29, 2026 19:26
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dsl rough edges identificationsurfaced a mismatch between DSL ergonomics and runtime behavior: calling.explain_plan()set an internal flag but did not affectexecute()unlessexplain_plan=Truewas also passed. This PR aligns builder intent with execution semantics.Runtime behavior alignment (
QueryBuilder.execute)execute()now honors_explain_plan_flagby enabling plan capture for the next call.one-shot), preventing state leakage across subsequent executions.Regression coverage (
tests/test_dsl_planner.py).explain_plan()-> firstexecute()includesresult.meta["plan"]execute()(without re-enabling) does not include plan metadata.explain_plan()restores plan capture on the same builder instance