Fixed some of the compiler warnings#127
Open
sebatkar wants to merge 1 commit into
Open
Conversation
Skeli789
reviewed
Jan 24, 2025
| #define asm_unified(x) asm(".syntax unified\n" x "\n.syntax divided") | ||
|
|
||
| #define ARRAY_COUNT(array) (sizeof(array) / sizeof((array)[0])) | ||
| #define NELEMS(arr) (sizeof(arr)/sizeof(*(arr))) |
Owner
There was a problem hiding this comment.
The solution for the issue caused by this isn't to change this line, but instead to remove the lines in dexnav.c that are throwing this warning. Those lines aren't used for anything.
| bool8 ShouldTrap(u8 bankAtk, u8 bankDef, u16 move, u8 class); | ||
| bool8 ShouldRecover(u8 bankAtk, u8 bankDef, u16 move); | ||
| u8 ShouldProtect(u8 bankAtk, u8 bankDef, u16 move); | ||
| ProtectQueries ShouldProtect(u8 bankAtk, u8 bankDef, u16 move); |
Owner
There was a problem hiding this comment.
Simpler to just change the function itself to return a u8 in the .C file
Contributor
Author
|
Thanks for the feedback :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for some of the compiler warnings.