AgilityShortcutTest

[wvanderp]

I was inspired by #54 (comment) , which asked why we did not use the built-in list of agility shortcuts.

The question was answered there, but the thought struck me that we could use a unit test to check if we have all the agility shortcuts.

So I made a test. It resulted in about 100 missing (of a total of around 280).

This unit test will fail right now, so the best course of action is to slowly start adding these shortcuts either to the shortcuts.tsv or to the ignore list in the test if there is a valid reason for it.

I hope to be slowly chipping away at the list, although some of it will be hard because I can't visit the area or take the shortcuts.

[Skretzo]

This is a good idea!

It is perfectly ok to add shortcuts you have not tested in-game. I try to check videos if possible or estimate the time it takes to use the shortcut based on the distance in number of tiles between start and end. Mejmap is very useful for this, as it allows you to see objects and even crowdsourced transports and teleports (although not up-to-date anymore since December 2021). When you hover or click the transport or tele pin you see the start and end tile and information about the transport (e.g. which object menu option was clicked, the object id, and sometimes which varbit controls the state of the object). Beware that it can be wrong in some cases, e.g. the start or end tile does not make sense and was somehow collected incorrectly.

[Copilot]

Pull request overview

Adds a new unit test intended to ensure RuneLite’s AgilityShortcut enum is fully represented in this plugin’s transport TSV data, and begins expanding the transport datasets to reduce gaps.

Changes:

• Added AgilityShortcutTest to compare RuneLite AgilityShortcut entries against loaded transport data.
• Added ObservatoryGrappleShortcutTest plus corresponding TSV/data adjustments for the Observatory grapple shortcut.
• Updated transport TSV resources (notably agility_shortcuts.tsv and transports.tsv) and tweaked CI logging / Gradle repository config.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/test/java/shortestpath/ObservatoryGrappleShortcutTest.java	Adds a focused unit test validating parsing/requirements for the Observatory grapple shortcut.
src/test/java/shortestpath/AgilityShortcutTest.java	Adds a coverage test intended to detect missing agility shortcuts vs RuneLite’s enum.
src/main/resources/transports/transports.tsv	Adds/adjusts various transport entries (e.g., Revenant Caves, Wintertodt, Temple of the Eye).
src/main/resources/transports/agility_shortcuts.tsv	Major edits/expansion, including quest column and many new/duplicated rows.
missing.md	Adds an apparent local build/test log artifact (should not be committed).
build.gradle	Changes repository ordering/removes mavenLocal().
.github/workflows/tests.yml	Runs Gradle with --info in CI.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.