Added cancellable ChangeGameModeEvent support - #10
Merged
Conversation
…ialization/deserialization, OnGameModeChange event and context values (old and new game mode), added cancellation support, and included name of support for game mode objects.
ShaneBeee
requested changes
Feb 5, 2026
ShaneBeee
left a comment
ShaneBeee
left a comment
Member
There was a problem hiding this comment.
Sorry I dont have a style guide setup, so this is just a bunch of nitpicks.
Looks good otherwise.
…ts/player/EvtPlayerChangeGameMode.java Co-authored-by: Shane Bee <shanebolenback@me.com>
…ts/player/EvtPlayerChangeGameMode.java Co-authored-by: Shane Bee <shanebolenback@me.com>
…ts/player/EvtPlayerChangeGameMode.java Co-authored-by: Shane Bee <shanebolenback@me.com>
…r. Removed serializer from type registration and changed to INSERT VERSION
Contributor
Author
|
I've made the changes, and you're right. IntelliJ is very insistent about "optimizing" imports. No worries about no style guide since it's knew, but thanks for letting me know regardless. |
Member
Not a worry. I didnt have an editoconfig setup but I do now. |
ShaneBeee
approved these changes
Feb 5, 2026
ShaneBeee
left a comment
ShaneBeee
left a comment
Member
There was a problem hiding this comment.
Looks good to me.
Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added game mode support preliminarily including GameMode type and serialization/deserialization, OnGameModeChange event and context values (old and new game mode), added cancellation support, and included name of support for game mode objects.
Target Hytale Versions: any
Requirements: none
Related Issues: TODO
Checklist before requesting a review