SK-2430: Add unit tests for detokenization UDF - #6
Merged
saileshwar-skyflow merged 6 commits intoDec 12, 2025
Merged
saileshwar-skyflow merged 6 commits into
saileshwar-skyflow merged 6 commits into
Conversation
skyflow-srivyshnavi
requested changes
Dec 11, 2025
There was a problem hiding this comment.
Pull request overview
This PR enhances test coverage for the Hive detokenization UDF by adding comprehensive unit tests across validation, helper, configuration, and main UDF classes. The goal is to increase coverage to approximately 80% and integrate code coverage tracking via JaCoCo.
- Added unit tests for
Validations,Helper,Config, andDetokenizeUDFclasses - Integrated JaCoCo plugin for code coverage reporting
- Added GitHub Actions workflow for automated coverage tracking
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
hive/detokenization/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker |
Enables inline mocking for Mockito to support mocking of final classes |
hive/detokenization/src/test/java/com/skyflow/hive/utils/ValidationsTest.java |
New comprehensive test suite for validation logic including session state, config, credentials, and file path validation |
hive/detokenization/src/test/java/com/skyflow/hive/utils/HelperTest.java |
Extended test coverage for helper utilities including credentials file and vault URL initialization scenarios |
hive/detokenization/src/test/java/com/skyflow/hive/utils/ConfigTest.java |
Migrated from JUnit 4 to JUnit 5 and added tests for partial field deserialization and getters |
hive/detokenization/src/test/java/com/skyflow/hive/DetokenizeUDFTest.java |
Enhanced UDF tests with success/failure scenarios, mocking improvements, and null input handling |
hive/detokenization/src/main/java/com/skyflow/hive/utils/Validations.java |
Added explicit exception handling to preserve UDFArgumentException in catch blocks |
hive/detokenization/pom.xml |
Added JaCoCo Maven plugin configuration for coverage reporting |
.github/workflows/detokenization-coverage.yml |
New CI workflow for running tests and uploading coverage reports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skyflow-srivyshnavi
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Outcome