Open
Conversation
Supports MTP testing Supports both Skyline.DataMiner.Sdk & NuGet projects Redirect existing NuGet & App Package workflows towards the Master Workflow Fix security concerns
c7e1d65 to
ee61492
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Introduce Unified Master Workflow
Overview
This PR introduces a new centralized Master Workflow (
Master Workflow.yml) that consolidates the full CI/CD pipeline for .NET solutions. The existing NuGet Solution, Internal NuGet Solution, and DataMiner App Packages wrapper workflows are refactored to delegate to this new Master Workflow, eliminating duplicated pipeline logic.New File
Master Workflow.ymlA new reusable
workflow_callworkflow that provides an end-to-end CI/CD pipeline with first-class support for both NuGet packages and DataMiner SDK packages (.dmapp/.dmtest). It dynamically adapts behavior based on project types discovered in the calling repo.Jobs (5):
.sln/.slnxfile and detects DataMiner SDK projects viaDataMinerTypein.csprojKey capabilities:
dotnet sign+ Azure Key Vaultdataminer-package-signaturemanifest.ymlSkyline.DataMiner.Sdk2.4.7,AppPackageInstaller4.0.0)Inputs:
oidc-client-id,oidc-tenant-id,oidc-subscription-id,sonarcloud-project-name(required),configuration,solution-filter-name,debug,override-catalog-identifiers,nuget-push-sourceSecrets (all optional):
SONAR_TOKEN,DATAMINER_TOKEN,AZURE_TOKEN,OVERRIDE_CATALOG_DOWNLOAD_TOKEN,NUGET_API_KEYModified Files
DataMiner App Packages Master Workflow.ymlMaster Workflow.yml.check_deprecated_itemjob (warns callers about obsolete inputs/secrets).sonarcloud-project-name,configuration,solution-filter-name,override-catalog-identifiers,debug) and secrets (SONAR_TOKEN,AZURE_TOKEN,DATAMINER_TOKEN,OVERRIDE_CATALOG_DOWNLOAD_TOKEN) to the Master Workflow.NuGet Solution Master Workflow.ymlMaster Workflow.yml.check_deprecated_itemjob (warns about obsolete inputs likereferenceName,pfx,pfxPassword, etc.).solutionName→solution-filter-name).nuget-push-sourcetohttps://api.nuget.org/v3/index.json(public NuGet.org).NUGET_API_KEY,SONAR_TOKEN,AZURE_TOKENsecrets.Internal NuGet Solution Master Workflow.ymlMaster Workflow.yml.check_deprecated_itemjob.solutionFilterName→solution-filter-name).nuget-push-source(defaults to GitHub Packages registry).NUGET_API_KEY,SONAR_TOKEN,AZURE_TOKENsecrets.Unchanged Files
Automation Master Workflow.yml— still routes to Legacy/SDK sub-workflows viaSDKCheckerAutomation Master Legacy Workflow.yml— standalone legacy pipeline (windows-latest)Automation Master SDK Workflow.yml— standalone SDK pipeline (windows-latest)Connector Master Workflow.yml— still routes to Legacy/SDK sub-workflows viaSDKCheckerConnector Master Legacy Workflow.yml— standalone legacy pipeline (windows-latest)Connector Master SDK Workflow.yml— standalone SDK pipeline (windows-latest)SRM Function Master Workflow.yml— standalone legacy pipelineUpdate Catalog Details Workflow.yml— standalone catalog details updater