Change span element to self-closing tag#194
Open
Matthew Robertson (metalix2) wants to merge 2 commits intomainfrom
Open
Change span element to self-closing tag#194Matthew Robertson (metalix2) wants to merge 2 commits intomainfrom
Matthew Robertson (metalix2) wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR changes a span element from an opening tag to a self-closing tag in a test fixture file for webpack message formatting.
Changes:
- Modified the span element in AppBabel.js to use self-closing syntax
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Alex Sannikov (xalechez)
approved these changes
Jan 23, 2026
Arnau González (arnaugm)
approved these changes
Jan 23, 2026
Simon Ward (Sybsw)
approved these changes
Jan 26, 2026
Simon Ward (Sybsw)
requested changes
Jan 30, 2026
Simon Ward (Sybsw)
left a comment
Simon Ward (Sybsw)
left a comment
There was a problem hiding this comment.
Apparently this is an intentionally broken js response that gets regression tested:
https://github.com/Skyscanner/backpack-react-scripts/blob/main/test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap#L23
Author
|
Well spotted, will raise to override in Cortex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could not process some files due to syntax errors
View file
A parse error occurred: Unterminated JSX contents. Check the syntax of the file. If the file is invalid, correct the error or exclude the file from analysis.