[Ascii art] Add child class representing letter object#11
Open
Slavunderkind wants to merge 2 commits intomasterfrom
Open
[Ascii art] Add child class representing letter object#11Slavunderkind wants to merge 2 commits intomasterfrom
Slavunderkind wants to merge 2 commits intomasterfrom
Conversation
Slavunderkind
changed the title
Slavunderkind
force-pushed
the
ascii_art_solution
branch
from
9639106 to
0b28097
Compare
Slavunderkind
force-pushed
the
ascii_art_solution
branch
from
0b28097 to
f7c9a34
Compare
ghost
reviewed
Jan 20, 2017
Training/Easy/ascii_art.rb
Outdated
| end | ||
|
|
||
| def letter_index(letter) | ||
| ascii_style = ('A'..'Z').to_a << '?' |
There was a problem hiding this comment.
You can move it to a constant AsciiArt::Letter::LETTERS, so that it reserves memory once.
LETTERS = [('A'..'Z').to_a, '?'].flatten
Collaborator
There was a problem hiding this comment.
You can also do
LETTERS = ('A'..'Z').to_a << '?'to reserve even more memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.