fix(ci): deploy plugin to all matching pods and fix language-file counter#13
Merged
Conversation
…nter The deploy script previously targeted a single pod even when the selector matched multiple replicas, so a scaled deployment ended up with the plugin only partially deployed and wp-admin flapping between old and new code depending on which pod served the request. generate-language-files.sh used `((compiled++))`, whose post-increment return value is 0 on the first iteration and aborts the script under `set -e` before any .mo file is compiled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-plugin-to-wordpress-pod.shnow deploys to every running pod matching the selector, not just the first one. Scaled deployments (multiple replicas) were left with a partially-deployed plugin, causing wp-admin to flap between old/new code depending on which pod served the request.generate-language-files.shused((compiled++)), whose post-increment return value is0on the first iteration and aborts the script underset -ebefore any.mofile is compiled.Test plan