Document node parameters and switch to config-file based launch - #8
Merged
Merged
Conversation
- Convert the parameter test launch file to load parameters from a YAML configuration file (config_file launch argument) instead of an inline parameter dict. - Add config/config.yaml with one block keyed by the effective node name 'sas_common_ros2_parameter_test', documenting all eight vector parameters (the four EMPTY_LIST markers and four representative non-empty vectors). - Add a 'ROS 2 Nodes & Parameters' README section with a parameter table. - Install the config/ directory into the package share directory. - Preserve the launch filename and node name to avoid breaking downstream references. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the standard "ROS 2 Nodes & Parameters" README section and converts the parameter-test launch file to the config-file-based pattern used by
sas_robot_driver_ur.Changes
sas_common_ros2_parameter_test_launch.pyto load parameters from a YAML configuration file via aconfig_filelaunch argument (previously an inline parameter dict).config/config.yamlwith one block keyed by the effective node namesas_common_ros2_parameter_test, documenting all eight vector parameters (the four["EMPTY_LIST"]markers and four representative non-empty vectors).ROS 2 Nodes & ParametersREADME section with a full parameter table.config/directory into the package share directory.Preserved behavior
sas_force_sensor_bota's docker compose).Verification
py_compiles cleanly; the YAML config parses and contains all eight expected parameter keys.sas::get_ros_parameterthat typed arrays (integer/double/bool) pass straight through and the["EMPTY_LIST"]string-array markers trigger the empty-list path — so the config-file values behave identically to the previous inline dict.Note: this PR was created by an AI agent (OpenHands) on behalf of the user.