Document node parameters and switch to config-file based launches - #18
Merged
Merged
Conversation
- Rename launch/sas_robot_driver_ros_composer_example.py to launch/composer_example_launch.py and convert it to load all parameters from config/config.yaml (config_file launch argument). - Add launch/composer_launch.py (single composer node) and launch/watchdog_launch.py (watchdog commander node). - Add config/config.yaml with parameter blocks for the three nodes (sas_robot_driver_ros_composer_node, sas_robot_watchdog_commander_node, and the two sas_robot_driver_ros_example instances named robot_1 and robot_2). - Add a 'ROS 2 Nodes & Parameters' section to the README (and update AGENTS.md) documenting every parameter of each node. - Install the config directory into the package share directory. Co-authored-by: openhands <openhands@all-hands.dev>
mmmarinho
commented
Aug 24, 2026
mmmarinho
left a comment
Member
Author
There was a problem hiding this comment.
Is the indentation in the config file correct?
Member
Author
|
Good question — I re-verified
So each node only receives its own block. If you were looking at a specific spot that still seems off, let me know which line and I will adjust it. This comment was created by an AI agent (OpenHands) on behalf of the user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the standard "ROS 2 Nodes & Parameters" README section and converts the launch files to the config-file-based pattern used by
sas_robot_driver_ur/sas_robot_driver_kuka.launch/sas_robot_driver_ros_composer_example.py→launch/composer_example_launch.pyand converts it to load all parameters fromconfig/config.yamlvia aconfig_filelaunch argument.launch/composer_launch.py(single composer node) andlaunch/watchdog_launch.py(watchdog commander node).config/config.yamlwith parameter blocks for the three nodes:sas_robot_driver_ros_composer_node,sas_robot_watchdog_commander_node, and the twosas_robot_driver_ros_exampleinstances (namedrobot_1androbot_2).ROS 2 Nodes & ParametersREADME section (and updatesAGENTS.md) documenting every parameter of each node (type, mandatory/optional, default, purpose).config/into the package share directory.Notes
robot_driver_client_namesentries are topic prefixes of the client nodes; the example launch keepsrobot_1/robot_2as the node names of the two example instances so each reads its own config block.Verification
python3 -m py_compilepasses on all launch files.config/config.yamlparses and contains blocks for all node instances; parameter names cross-checked against the node sources.Note: this PR was created by an AI agent (OpenHands) on behalf of the user.