Skip to content

feat: enhance StellarLend documentation, setup guide, and developer workflow#413

Open
Tobiloba0 wants to merge 1 commit into
Smartdevs17:mainfrom
Tobiloba0:fix/issue-358
Open

feat: enhance StellarLend documentation, setup guide, and developer workflow#413
Tobiloba0 wants to merge 1 commit into
Smartdevs17:mainfrom
Tobiloba0:fix/issue-358

Conversation

@Tobiloba0
Copy link
Copy Markdown

What Changed

  • Code:Fixed TypeScript compilation errors across the api workspace by:
    • Adding missing next: NextFunction parameters to Express handlers in:
    • debtToken.controller.ts
    • lending.controller.ts
    • rebalancing.controller.ts
    • Resolving a naming/call mismatch in portfolio.controller.ts by renaming the import to buildHealthFactorMonitor and updating its usage.
    • Extending WebSocket types in index.ts to include analytics subscribe/unsubscribe messages (subscribe_analytics / unsubscribe_analytics) and corresponding server messages.
  • Behavior: Restores successful TypeScript builds and enables clients to request analytics subscriptions over the API WebSocket protocol.

Why

  • The repository's api build was failing due to handler functions calling next(error) without declaring the next parameter, and WebSocket client message types lacked analytics subscription messages.
  • These issues prevented workspace builds and blocked development & testing on branch fix/issue-358. The changes fix the root causes so the API compiles cleanly and correctly types analytics WS messages.

Testing

  • Unit tests updated or added
  • Relevant local checks passed — ran cd api && npm run build and npm --workspaces run build --if-present (both succeeded)
  • Manual verification completed when needed — verified TypeScript compilation and workspace builds

Closes #358

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

@Tobiloba0 is attempting to deploy a commit to the smartdevs17's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Tobiloba0
Copy link
Copy Markdown
Author

Vercel deployment requires authorization from maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor storage layout to use packed encoding for gas efficiency

1 participant