SMOODEV-1527: Fix eso-refresher keep-alive (don't unref the interval)#109
Closed
brentrager wants to merge 1 commit into
Closed
SMOODEV-1527: Fix eso-refresher keep-alive (don't unref the interval)#109brentrager wants to merge 1 commit into
brentrager wants to merge 1 commit into
Conversation
The refresher exited 0 right after its initial mint+write — it unref'd the
interval timer, and the 'await new Promise(() => {})' keep-alive in main() does
NOT hold Node's event loop open on its own. Result: the sidecar CrashLoopBackOff'd
(re-minting on each restart, which masked it, but it's not a stable daemon).
Don't unref the production interval — it's what keeps the loop alive. Tests
inject their own scheduler, so they're unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 56aab8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Superseded: deployed the refresher as a CronJob (one-shot mint+exit every 10m) instead of a long-running Deployment, which sidesteps the keep-alive concern entirely and is the better pattern for periodic token refresh. A follow-up will add an explicit one-shot mode to the refresher rather than relying on mint-then-exit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refresher exited 0 right after its initial mint — it
unref()'d the interval timer, andawait new Promise(() => {})doesn't hold Node's event loop open. Result: CrashLoopBackOff (it re-minted on each restart, masking it). Don't unref the production interval. Tests inject their own scheduler. Part of the ESO cutover (SMOODEV-1527 / epic SMOODEV-1522).