SMOODEV-1787: consume published smooth-operator-core; delete in-tree copy (PR 1/4)

[brentrager]

Problem

PR 1 of 4 in the program to decouple the `th code` coding harness from the public agent engine.

`smooth` was building against an in-tree copy of the agent engine at `crates/smooth-operator` (`smooai-smooth-operator`), which had diverged from the published public engine `smooai-smooth-operator-core` (`github.com/SmooAI/smooth-operator-core`). Two copies of the same engine is the root problem this program removes.

Solution

`smooth` now consumes the published `smooth-operator-core` engine; the in-tree copy is deleted. The ~12 consumers compile unchanged — this is the dual-engine collapse only. No functional change, no module removal (that lands in later PRs).

Divergence analysis (full diff of both `src/` trees + Cargo.toml)

The two engines differed in only two ways, neither of which smooth depends on:

1. Dormant BigSmooth coupling — the public core gates its `bigsmooth_client` (`BigSmoothReporter`/`ReporterEvent`/`ControlEvent`) behind a `bigsmooth` cargo feature, with a no-op `report_to_bigsmooth` stub + stand-in `ReporterEvent` enum when disabled. The in-tree copy wired the reporter unconditionally. smooth never enables the `bigsmooth` feature and never sets a reporter (verified: zero consumers reference `BigSmoothReporter` / `with_reporter` / `.reporter` / `ReporterEvent` / `ControlEvent`), so these calls were dormant no-ops. Nothing is lost.
2. Cosmetic public-sanitization — doc-comment rewording (removing internal names like "Big Smooth"/"Wonk"/"microVM" and pearl IDs), `smooth_operator` → `smooth_operator_core` in doc examples, neutralized example hosts in tests (`llm.smoo.ai` → `gateway.example.com`), a provider-agnostic `ModelRouting::default()` (consumers load routing from file / pick presets explicitly — no consumer depends on the default alias strings), a redacting `Debug` for `ProviderConfig`/`LlmConfig` (a strict improvement), and a wider retry-status set. All public API signatures the consumers use are identical; the public core still exports `Preset::SmoaiGateway`, `Preset::ALL`, `Preset::from_name`, `ProviderConfig::smooai_gateway`, etc.

No port into the core was needed — there was no in-tree-only code that smooth's consumers use and the public core lacks.

Wiring

• Workspace `smooth-operator` dep repointed to the published engine, package-aliased so `use smooth_operator::…` keeps resolving:
  `smooth-operator = { git = "https://github.com/SmooAI/smooth-operator-core.git", rev = "bb9a256…", package = "smooai-smooth-operator-core" }`
• Pinned as a rev-locked git dep, not a sibling `../` path dep — a path dep only resolves on a dev laptop and breaks CI's `cargo metadata` step, the exact failure SMOODEV-1464 hit with `client-shared`.
• The two crate-level path-dep overrides (`smooth-bigsmooth`, `smooth-operative`) converted to `smooth-operator.workspace = true`.
• `crates/smooth-operator/` deleted (38 files, ~20k lines); removed from the workspace via the `crates/*` glob.

Verification (real output)

• `smooth-operator-core`: nothing ported — no core change in this PR.
• `smooth`: `cargo build --workspace` → clean (all ~12 consumers compile unchanged: th/smooth-cli, smooth-bigsmooth, smooth-operative, smooth-code, smooth-narc, smooth-pearls, smooth-scribe, smooth-wonk, smooth-plugin, smooth-bench). `cargo test --workspace` → all suites green except a pre-existing concurrency flake (`smooth-bench` `current_commit_sha_returns_something_non_empty` shells out to `git rev-parse HEAD` and races other subprocess-spawning bench tests under parallel load; passes in isolation, and is in `sweep.rs` which this PR never touches).
• `cargo metadata` resolves cleanly (the SMOODEV-1464 failure mode); `Cargo.lock` now sources the engine from `git+…?rev=bb9a256…`; old `smooai-smooth-operator` is gone from the lockfile; no remaining `path = ".../smooth-operator"` dep references.

🤖 Generated with Claude Code

[changeset-bot]

🦋 Changeset detected

Latest commit: 0dfa72b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@smooai/smooth	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR