Mark ReportHook & ParameterizedTest as used#588
Open
jamesjer wants to merge 1 commit intoSnaipe:bleedingfrom
Open
Mark ReportHook & ParameterizedTest as used#588jamesjer wants to merge 1 commit intoSnaipe:bleedingfrom
jamesjer wants to merge 1 commit intoSnaipe:bleedingfrom
Conversation
Collaborator
|
Hi @jamesjer, Thanks for your PR! I'll try to reproduce the issue soon. Doesn't this mean that we might be missing additional symbols that are not directly mentioned in the executable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With criterion 2.4.3, I tried running the cram tests on an x86_64 Fedora 43 machine. The parameterized and report tests failed due to missing output. In both cases, the linker had discarded the test code while building the executable. This PR adds
usedattributes to prevent that from happening. With this change, all of the cram tests pass on my machine.