fix: restore mixed-filament confirmation when switching to Preview tab - #783
Closed
iesteem wants to merge 1 commit into
Closed
fix: restore mixed-filament confirmation when switching to Preview tab#783iesteem wants to merge 1 commit into
iesteem wants to merge 1 commit into
Conversation
A regression from #589 removed the confirmation dialog on Prepare -> Preview switch. When the switch would auto-start slicing and the plate has mixed high/low temperature filaments (allowed via Preferences), show the same single-plate confirmation as the Slice Plate button; declining stays on the Prepare page without slicing. Also align the slice-all confirmation text with the single-plate dialog by including the risk warning sentence. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the secondary confirmation dialog for mixed high/low temperature filaments when switching from the Prepare tab to the Preview tab.
Background
When a plate mixes high-temperature and low-temperature filaments and "Allow high/low temperature filament mixing" is enabled in Preferences:
(In 2.3.5 the Preview switch was implemented by re-posting the "Slice All" event, which incidentally carried the confirmation. #589 removed that repost — correctly, because it sliced all plates when only the selected plate should be sliced — but the confirmation was lost along with it.)
Changes
EVT_GLVIEWTOOLBAR_PREVIEWhandler inPlater.cpp): when the switch would auto-start slicing and the current plate has mixed high/low temperature filaments, show the same single-plate confirmation dialog as the Slice Plate button.Plater::preview_switch_triggers_slice()(Plater.cpp/Plater.hpp): mirrors the slice branch conditions ofPlater::priv::set_current_panel'sdo_reslice(non-empty model, printable instances on the current plate, stale slice result, no export/slicing in progress, model inside the print volume), so the dialog only appears when slicing would actually start.filament_temp_mixing_warning_text_slice_all()now includes the same risk-warning sentence ("Mixed printing may result in extruder clogging, nozzle damage, or layer adhesion issues.") that was previously missing from the slice-all variant.Hard-blocked plates (mixing not allowed via Preferences) keep the existing behavior: notification sync + no slicing, no dialog.
Screenshots/Recordings/Graphs
N/A (behavioral fix; dialog layout unchanged — only the slice-all warning text gained the risk sentence).
Tests
libslic3r_guipasses (MSVC).