fix: hex layer now only updates once when changed#1
Open
Rizq0 wants to merge 1 commit intoSnappey:masterfrom
Open
fix: hex layer now only updates once when changed#1Rizq0 wants to merge 1 commit intoSnappey:masterfrom
Rizq0 wants to merge 1 commit intoSnappey:masterfrom
Conversation
Author
|
Ignore the prettier formatting, but seemed to have fixed the layer duplication. I believe there was a form of duplication happening when the hex layer changed. When the shard changed, the event listening was calling initialiseLayers (this.updateHexSectorsLayer(shard);), but the hex sector layers was also managed by hexSectorsEffect. They were both reacting to the same change sometimes causing duplicates to appear. I removed this.updateHexSectorsLayer(shard); from initaliseLayers and in turn the updateHexSectorsLayer method. Instead, hexSectorsEffect is listening for a shard change and handleHexSectorsVisibility now removes the layer first to then get the updated layer when an event happens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.