Fix timeline nav scroll-to-top on current timeline#2133
Merged
Conversation
2ff9302 to
f9e8938
Compare
f9e8938 to
16e1644
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the app header’s Home/Public navigation so that clicking the currently-active timeline link triggers the existing Timeline “scroll to top” behavior (instead of re-navigating), while keeping normal navigation behavior for other routes and modified clicks.
Changes:
- Add a route-targeted scroll-to-top request mechanism via a window
CustomEvent. - Intercept same-route clicks on Home/Public header links to dispatch a targeted scroll-to-top request.
- Wire
Timelineinstances on/homeand/publicto listen for scroll-to-top requests for their own route only.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/routes/(app)/public/+page.svelte | Passes scrollToTopTarget="/public" to the public timeline so it can respond only to relevant scroll-to-top requests. |
| web/src/routes/(app)/home/+page.svelte | Passes scrollToTopTarget="/home" to the home timeline so it can respond only to relevant scroll-to-top requests. |
| web/src/routes/(app)/Header.svelte | Adds same-route click handling for Home/Public to dispatch a targeted scroll-to-top request while preserving normal navigation otherwise. |
| web/src/lib/timelines/ScrollToTop.ts | Introduces a small event-based API to request and subscribe to timeline scroll-to-top actions by target key. |
| web/src/lib/components/Timeline.svelte | Adds an optional scrollToTopTarget prop and registers a scroll-to-top listener on mount to call the existing scrollToTop() behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan