Repository navigation
tests:独立评审 watch 夹具的评论补上可信作者(delivery-harness T702 前置 D5) - #76
Merged
Merged
Conversation
delivery-harness 的自治试验(B81)中,T702 上线后 watch 只认 checks.toml [identity] agent_login 写的评审标记。BackgroundTest 夹具里的两条评论原来没有 author,新引擎下 #3 会被 当成未评审,待评审集合会从 [1, 4] 变成 [1, 3, 4]。补上 author 后,新旧引擎下结果都是 [1, 4]: 旧引擎的 reviewed_heads 不看作者,结果不变。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SnowsonZ
approved these changes
Oct 3, 2026
SnowsonZ
left a comment
Owner
There was a problem hiding this comment.
独立评审 watch 夹具评论补可信作者(delivery-harness T702 前置 D5),harness 与 build 全绿,按用户决定批准合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
需要你决定的
批准合并。合并后,delivery-harness 才能派发 T702。原因是那边的消费方契约 CI 会检出本仓库 main 来跑这组测试。
内容
只改
tests/test_harness_review_independent.py的 BackgroundTest 夹具:给两条带评审标记的评论补上"author": {"login": "Snowson"},即checks.toml [identity] agent_login。reviewed_heads不看作者;新引擎认得出可信作者。两边的待评审集合都是[1, 4]。已核对
python3 -m unittest tests.test_harness_review_independent通过;推送前的bin/verify也通过。🤖 Generated with Claude Code