fix(tests): correct trust-chain test import (unblocks sociosphere validate) - #51
Merged
Conversation
The test imported 'from tools.validate_trust_chain_agent_manifest_binding' but tools/ has no __init__.py and every other test in this dir uses the bare 'from validate_… import' form, so collection failed with ModuleNotFoundError — blocking the Python-tests 'validate' job on every sociosphere PR (CI clones agent-registry). Matches the working convention; 3 passed locally.
There was a problem hiding this comment.
Pull request overview
This PR aims to fix pytest collection failures in tools/tests/test_trust_chain_agent_manifest_binding.py by correcting an invalid import path for the trust-chain validator script under tools/.
Changes:
- Updates the test to import
validate_trust_chain_agent_manifest_bindingwithout thetools.package prefix.
Comment on lines
3
to
7
| import json | ||
| from pathlib import Path | ||
|
|
||
| from tools.validate_trust_chain_agent_manifest_binding import main as validate_trust_chain_agent_manifest_binding | ||
| from validate_trust_chain_agent_manifest_binding import main as validate_trust_chain_agent_manifest_binding | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/tests/test_trust_chain_agent_manifest_binding.pyimportedfrom tools.validate_… import main, buttools/is not a package (no__init__.py) and every other test in the directory imports the barefrom validate_… importform. Pytest collection therefore fails withModuleNotFoundError: No module named 'tools.validate_trust_chain_agent_manifest_binding'.This blocks the
Python testsstep of thevalidatejob on every sociosphere PR (sociosphere CI clones this repo), including GBRG PR SocioProphet/sociosphere#509. Fix drops the staletools.prefix to match the repo's own convention.pytest tests/test_trust_chain_agent_manifest_binding.py→ 3 passed.🤖 Generated with Claude Code