initial-version-sam-kong-ai codelab#388
Conversation
|
Initial version for review and test. Not ready for merge yet |
|
@Chaymee - based on the Immersion Day workshop. Could you kindly review, please? |
There was a problem hiding this comment.
✨ PR Review
This PR introduces comprehensive codelab documentation and configuration files for integrating Solace Agent Mesh with Kong AI Gateway. The content is well-structured and detailed, providing step-by-step instructions for setting up the integration.
2 issues detected:
🐞 Bug - The curl --variable syntax is malformed and won't properly expand the KONNECT_PROXY_URL environment variable 🛠️
Details: The curl command uses incorrect syntax for variable expansion. The
--variable %KONNECT_PROXY_URLformat does not match curl's documented variable syntax, which should be--variable name=valueor reference an environment variable differently. This will cause the command to fail when users try to execute it.File:
markdown/solace-agent-mesh-kong-ai/solace-agent-mesh-kong-ai.md (266-266)
🛠️ A suggested code correction is included in the review comments.🔒 Security - The fallback "nokey" value could allow deployment with invalid authentication credentials without clear error feedback 🛠️
Details: The Authorization header includes a fallback value of "nokey" when the MCP_MARKETPLACE_TOKEN environment variable is not set. This could result in authentication bypass attempts or unclear failures when the token is missing, and users might deploy configurations without realizing the token wasn't properly configured.
File:
markdown/solace-agent-mesh-kong-ai/assets/marketplace_agent.yaml (45-45)
🛠️ A suggested code correction is included in the review comments.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how
markdown/solace-agent-mesh-kong-ai/solace-agent-mesh-kong-ai.md
Outdated
Show resolved
Hide resolved
|
Please mark whether you used Copilot to assist coding in this PR
|
with necessary changes found while going through the codelab
Co-authored-by: gitstream-cm[bot] <111687743+gitstream-cm[bot]@users.noreply.github.com>
|
Updated with a basic change for SAM -> Solace Agent Mesh. We are trying to be consistent with branding. Otherwise I think this is good. I have thoughts for improvements in the future, and to bring to github codespaces like our other workshops but I will do that after we execute the workshop with Kong |
these should work once this fiel is merged into master on the main repo
|
Fixed the external file references, links should work once this is merged into master. |

✨ PR Description
Purpose: Add comprehensive codelab documentation and configuration files for integrating Solace Agent Mesh with Kong AI Gateway to enable secure, event-driven agentic AI workflows.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how