depreciate uint64ToString() - #10
Open
junwoo091400 wants to merge 2 commits into
Open
Conversation
previously, it was doing bit shift operation, and then truncated the string. but since the values given to this function won't go over 4 billion for sure, this won't make any difference really :(
Setting values aren't as big as uint64_t. So there is no reason to use that function.
junwoo091400
changed the title
Author
|
I think it is better not to use such function. We don't have any setting data that big anyway. And even if it is over 32-big boundary, that would require 10 digits. And I don't know if OLED can display that :) |
Owner
|
Yeah you are right, however, I am trying to get rid of the whole String constructor, as it takes up quite a lot of memory - and the whole sketch size is on the limit of the Atmega328p. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just uint64ToString function fix. Won't have any visual / performance difference.