Skip to content

fix(smart-home,dashboard): restore all-apps link, fix chart grid over… #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsanjavaid merged 2 commits into from
Aug 3, 2026
Merged

fix(smart-home,dashboard): restore all-apps link, fix chart grid over… #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4f19a9
fix(smart-home,dashboard): restore all-apps link, fix chart grid over…
ehsanjavaid Aug 3, 2026
2b5284b
test: update pinned CSS cache version expectation to v=52
ehsanjavaid Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion solvronix_desk/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# ── AUTHENTICATED DESK ASSETS ──────────────────────────────────────────────────
# Query versions are bumped whenever an asset changes to invalidate browser cache.
app_include_css = [
"/assets/solvronix_desk/css/solvronix_desk.css?v=51",
"/assets/solvronix_desk/css/solvronix_desk.css?v=52",
"/assets/solvronix_desk/css/sidebar.css?v=21",
"/assets/solvronix_desk/css/command_palette.css?v=4",
"/assets/solvronix_desk/css/smart_home.css?v=7",
Expand Down
18 changes: 18 additions & 0 deletions solvronix_desk/public/css/solvronix_desk.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2460,3 +2460,21 @@ html[dir="rtl"] #st-lang-dropdown {
background: var(--st-brand);
color: white;
}

/* ── DASHBOARD CHART GRID OVERFLOW FIX ───────────────────────────────────────
Frappe's own .widget-group .grid-col-2 uses bare `1fr 1fr` tracks, which
default to minmax(auto, 1fr) — the track's minimum is its content's
max-content size, not 0. Frappe Charts' own ResizeObserver reads the
rendered chart container width to redraw responsively; because the track
can grow to fit content instead of being capped at the container, each
redraw can nudge the track wider, which nudges the chart wider next time —
a feedback loop that pushes the second column further right on every
resize cycle until it's cut off past the viewport edge. minmax(0, 1fr)
hard-caps the track at its fair share of the container, breaking the
loop; min-width: 0 does the same for the grid item itself. */
.widget-group .grid-col-2 {
grid-template-columns: minmax(0, 1fr) minmax(0, 1fr) !important;
}
.widget-group .grid-col-2 > .widget.dashboard-widget-box {
min-width: 0;
}
2 changes: 1 addition & 1 deletion solvronix_desk/solvronix_desk/page/smart_home/smart_home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ solvronix_desk.SmartHome = class SmartHome {
this._icon("edit", "sm") +
'<span class="st-sh-customize-label">' + __("Customize layout") + '</span>' +
'</button>' +
'<a href="/desk/home" class="st-sh-all-ws">' +
'<a href="/desk/all-apps" class="st-sh-all-ws">' +
__("All Workspaces") + ' <span aria-hidden="true">&rarr;</span>' +
'</a>' +
'</div>' +
Expand Down
2 changes: 1 addition & 1 deletion tests/test_workspace_editorjs_popover_css.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_block_with_open_editorjs_popover_is_promoted_before_focus(self):
def test_workspace_css_cache_is_bumped(self):
hooks = HOOKS.read_text(encoding="utf-8")

self.assertIn("/assets/solvronix_desk/css/solvronix_desk.css?v=51", hooks)
self.assertIn("/assets/solvronix_desk/css/solvronix_desk.css?v=52", hooks)
self.assertIn("/assets/solvronix_desk/js/solvronix_desk.js?v=51", hooks)


Expand Down