Skip to content

Fixes - #21

Merged
ehsanjavaid merged 2 commits into
Solvronix:mainfrom
defendicon:main
Aug 11, 2026
Merged

ehsanjavaid merged 2 commits into
Solvronix:mainfrom
defendicon:main

Conversation

@defendicon

@defendicon defendicon commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Prevent Theme Studio contextual inspectors from opening automatically when switching preview scenes or opening a full settings section.
  • Apply published semantic success, warning, error, and info colors to Desk indicators, pills, badges, and alerts.
  • Switch a color-blind preset back to custom semantic colors when an individual status color is edited.
  • Add the 2.1.1 changelog entry and version/cache bumps.

Visible status-color behavior

The .indicator-pill.orange change is intentional. Orange pills previously used the brand accent token (--st-accent); they now share the semantic warning token (--st-warning) with yellow indicators and warning badges. This keeps Frappe warning states consistent and makes them respond to the published Theme Studio warning color.

Tests

  • python -m pytest -q — 116 passed, 4 subtests passed
  • node --test tests/*.test.js — 180 passed

Commit structure

  • fix(theme-studio): prevent inspectors from opening on scene switch
  • fix(theme): apply semantic colors to Desk status badges

@ehsanjavaid
ehsanjavaid self-requested a review August 8, 2026 14:34
@ehsanjavaid

Copy link
Copy Markdown
Contributor

Thanks for this — the fixes look solid and both test suites pass clean (25/25 Python, 164/164 JS). Two things before we merge:

  1. CHANGELOG.md + version bump — this repo requires a CHANGELOG.md entry and a semver bump (in pyproject.toml/hooks.py) per fix. Neither is in this PR yet. Could you add an entry describing both fixes (inspector auto-open prevention + semantic status colors) and bump the version accordingly?

  2. .indicator-pill.orange color change — right now orange pills use the brand accent color (--st-accent), but this PR merges orange into the same bucket as yellow/warning, so it'll render as the warning-amber token instead. Is that intentional? If so, could you mention it in the PR description (and ideally a before/after screenshot), since it's a visible behavior change beyond the stated scope of "apply semantic colors to status badges."

Also, could you squash the merge-commit noise (#7, #8, the merge from your fork's main) so the history reads as one clean change per fix? Happy to merge once those are in.

@defendicon

Copy link
Copy Markdown
Contributor Author

@ehsanjavaid Please Check

@ehsanjavaid
ehsanjavaid merged commit 287c77f into Solvronix:main Aug 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants