You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prevent Theme Studio contextual inspectors from opening automatically when switching preview scenes or opening a full settings section.
Apply published semantic success, warning, error, and info colors to Desk indicators, pills, badges, and alerts.
Switch a color-blind preset back to custom semantic colors when an individual status color is edited.
Add the 2.1.1 changelog entry and version/cache bumps.
Visible status-color behavior
The .indicator-pill.orange change is intentional. Orange pills previously used the brand accent token (--st-accent); they now share the semantic warning token (--st-warning) with yellow indicators and warning badges. This keeps Frappe warning states consistent and makes them respond to the published Theme Studio warning color.
Thanks for this — the fixes look solid and both test suites pass clean (25/25 Python, 164/164 JS). Two things before we merge:
CHANGELOG.md + version bump — this repo requires a CHANGELOG.md entry and a semver bump (in pyproject.toml/hooks.py) per fix. Neither is in this PR yet. Could you add an entry describing both fixes (inspector auto-open prevention + semantic status colors) and bump the version accordingly?
.indicator-pill.orange color change — right now orange pills use the brand accent color (--st-accent), but this PR merges orange into the same bucket as yellow/warning, so it'll render as the warning-amber token instead. Is that intentional? If so, could you mention it in the PR description (and ideally a before/after screenshot), since it's a visible behavior change beyond the stated scope of "apply semantic colors to status badges."
Also, could you squash the merge-commit noise (#7, #8, the merge from your fork's main) so the history reads as one clean change per fix? Happy to merge once those are in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visible status-color behavior
The
.indicator-pill.orangechange is intentional. Orange pills previously used the brand accent token (--st-accent); they now share the semantic warning token (--st-warning) with yellow indicators and warning badges. This keeps Frappe warning states consistent and makes them respond to the published Theme Studio warning color.Tests
python -m pytest -q— 116 passed, 4 subtests passednode --test tests/*.test.js— 180 passedCommit structure
fix(theme-studio): prevent inspectors from opening on scene switchfix(theme): apply semantic colors to Desk status badges