Skip to content

fix: joined button-group corners and dark-mode contrast (v2.1.2) - #23

Merged
ehsanjavaid merged 1 commit into
mainfrom
fix/btn-group-corners-22
Aug 12, 2026
Merged

ehsanjavaid merged 1 commit into
mainfrom
fix/btn-group-corners-22

Conversation

@ehsanjavaid

Copy link
Copy Markdown
Contributor

Fixes #22.

What was wrong

  • Grouped list-view buttons (Filter/clear-filter, sort field/sort-order) rendered as visually separate pills instead of one joined control — the theme's uniform border-radius on .btn-primary/.btn-default/.btn-secondary was overriding Bootstrap's corner-flattening for .btn-group children.
  • In dark mode, the active "Filters" button label was unreadable (near-black text on a near-black background) — --bg-dark-gray had collapsed to the page background instead of staying a lighter chip surface.
  • In dark mode, unchecked checkboxes rendered as the browser's default white box — Frappe's checkbox CSS never sets an unchecked background color.

Fix

  • Restore Bootstrap's .btn-group corner-flattening, re-asserted after the theme's blanket button radius.
  • Map --bg-dark-gray to the same lighter --gray-500 token stock Frappe's dark theme uses for that pairing.
  • Give unchecked checkboxes an explicit dark background in dark mode.
  • Bump app_version to 2.1.2 and the solvronix_desk.css/dark_mode.css cache-busters.

Verified against a live browser session (screenshots + computed-style checks) on both erp.solvronix.com and poultry-staging.solvronix.com. All 116 Python + 180 JS tests pass.

Restores Bootstrap's joined-corner styling for grouped buttons
(Filter/clear, sort field/order) that the theme's uniform border-radius
was overriding. Also fixes dark mode: --bg-dark-gray had collapsed to
the page background, making active-filter button text unreadable, and
unchecked checkboxes had no dark background so they showed as native
white boxes.

Fixes #22
@ehsanjavaid
ehsanjavaid merged commit f86418c into main Aug 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combobox not nice

1 participant