Skip to content

fix dropdown checkbox column bug #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsanjavaid merged 1 commit into from
Sep 15, 2026
Merged

fix dropdown checkbox column bug #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion solvronix_desk/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# ── AUTHENTICATED DESK ASSETS ──────────────────────────────────────────────────
# Query versions are bumped whenever an asset changes to invalidate browser cache.
app_include_css = [
"/assets/solvronix_desk/css/solvronix_desk.css?v=58",
"/assets/solvronix_desk/css/solvronix_desk.css?v=59",
"/assets/solvronix_desk/css/sidebar.css?v=31",
"/assets/solvronix_desk/css/command_palette.css?v=4",
"/assets/solvronix_desk/css/smart_home.css?v=7",
Expand Down
17 changes: 15 additions & 2 deletions solvronix_desk/public/css/solvronix_desk.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,8 +1429,21 @@ html[data-theme="dark"] #st-powered-by {
color: var(--st-text, #1A1A2E);
}

/* ── MISC UI POLISH ─────────────────────────────────────────────────────────── */

/* Link-field dropdown (awesomplete) must paint above the DataTable's sticky
checkbox column. Frappe core (.awesomplete > [role="listbox"]) and the
bundled frappe-datatable library's sticky top-left corner cell
(.dt-cell--sticky-top, the "select all" checkbox) both independently use
z-index: 4 — an exact tie. On any report where a Link filter sits directly
above the grid (e.g. the Bull filter on Bull Performance Report), the
dropdown's on-screen position overlaps that sticky cell, and with a tied
z-index the browser falls back to DOM order, so the checkbox bleeds
through the dropdown inconsistently. 20 is chosen to sit comfortably above
frappe-datatable's own highest z-index (.dt-dropdown__list: 10, its column
header menu), while staying well below this theme's modal/toolbar layers
(1040–1200), so it never covers something it shouldn't. */
.awesomplete > [role="listbox"] {
z-index: 20 !important;
}
/* Dropdown menus — z-index above our toolbar (1060) so they're never hidden by it */
.dropdown-menu,
.frappe-menu {
Expand Down
2 changes: 1 addition & 1 deletion tests/test_workspace_editorjs_popover_css.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_block_with_open_editorjs_popover_is_promoted_before_focus(self):
def test_workspace_css_cache_is_bumped(self):
hooks = HOOKS.read_text(encoding="utf-8")

self.assertIn("/assets/solvronix_desk/css/solvronix_desk.css?v=58", hooks)
self.assertIn("/assets/solvronix_desk/css/solvronix_desk.css?v=59", hooks)
self.assertIn("/assets/solvronix_desk/js/solvronix_desk.js?v=63", hooks)


Expand Down