Repository navigation
fix(saml,otel): send new email-verification and start-span settings - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream spec 1.1.1 added fields to two full-replacement PUTs the CLI could not send or round-trip.
SAML (
PUT /settings/sso/saml):emailVerifiedRequiredandmapping.emailVerifiedare now required by current n8n (additionalProperties: false). The CLI dropped them ongetand rejected them inset --input(strict decode).--email-verified-requiredand--email-verified-attributeset or override the--inputvalues (explicit false/empty wins).get --output json | set --input -now round-trips losslessly.OTel (
PUT /settings/otel):emitWorkflowStartSpanandemitNodeStartSpandefault tofalsewhen omitted. Everyotel setsilently turned both off, or hit 409 when env pins one totrue.--emit-workflow-start-spanand--emit-node-start-span.Compatibility decision
The new fields are not required locally. Older instances do not know them and likely reject them, so absent stays absent in both
getoutput andsetrequests. This keeps the union contract (target vs upstream). Making the SAML fields strictly required is a one-line change inSetSAMLConfigurationRequest.Validate.Evidence
setwas run against a live instance.--context admin):GET /settings/otelon the target does not returnemitWorkflowStartSpan/emitNodeStartSpan, so the target predates spec 1.1.1; the dev build'sotel get --output jsondoes not invent them.GET /settings/sso/samlanswers 403 there, so SAML is unverified live.Tests
get --output json | set --input - --yesround trip for both groups, older-instance documents warn and omit, flag overrides (fill, explicit false/empty, unset keeps input), 400/409 hints, help for new flags.make docs+make checkgreen locally.🤖 Generated with Claude Code