Repository navigation
feat(node-policy): add notloaded warnings and shared document scope docs - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Node type policy ops are now tagged Preview in the upstream spec (n8n Public API 1.1.1), and the write-result warnings changed shape. This PR updates the client and CLI to match.
Warnings carry
kind(breaking fix)NodeTypePolicyWarninggainskind(shadowed|notLoaded);shadowedByRuleIdis omitted when empty. Unknown kinds are kept as sent.set --output jsonnow keepskind, sonotLoadedandshadowedcan be told apart.notLoaded. An unknown kind gets a generic line.set --inputnow ignoreswarningsas raw JSON. Before, a raw API response or a previoussetoutput failed withunknown field "kind", even though the help said warnings were accepted.get → edit → set semantics (help only, no wire change)
get/sethelp now say that GET returns the rules of every attached document combined, while PUT writes only the scope's own document. It warns that a round trip copies rules from shared documents into the scope's own document.make docs).Not in this PR
Evidence
openapi.upstream.yml1.1.1,policyEffectiveWriteResultPublicDto, the PUT instance/project and attachment descriptions).notLoaded; the help wording ("selects node types this instance has not loaded") comes from the name.Tests
kind, plus anotLoadedcase.kindand omitsshadowedByRuleIdfornotLoaded; unknown-kind rendering; a previoussetoutput, a raw API response, and an unknown warning shape all accepted as--inputwithout sending backwarnings/scopeId; client encode round trip.make checkgreen.🤖 Generated with Claude Code