Skip to content

feat(policy): add reusable documents and scope attachments - #37

Merged
SomeoneWithOptions merged 1 commit into
mainfrom
feat/policy-documents
Oct 22, 2026
Merged

SomeoneWithOptions merged 1 commit into
mainfrom
feat/policy-documents

Conversation

@SomeoneWithOptions

Copy link
Copy Markdown
Owner

What / why

Expose reusable node and credential type policy documents and scope attachments through the CLI. Add credential instance/project policies so both Preview APIs support the full policy workflow.

Changes

  • Implement all 18 operations across phases 32–33 through a shared typed client and command builders.
  • Add strict JSON input validation, credential extends selectors, version checks, attachment uniqueness checks, mutation confirmations, and actionable errors.
  • Support cursor pagination with a 10,000-document collection cap; regenerate command documentation and update the coverage manifest.
  • Add client, CLI, help, pagination, and opt-in integration tests. Attachment write integration tests use only newly created test projects and detach documents before cleanup.

Verification

  • make check passes locally: formatting, vet, staticcheck, unit tests, race tests, all five cross-builds, tidy check, and vulnerability scan (No vulnerabilities found.).
  • make docs run after rebasing; generated docs remain current and working tree clean.
  • No secrets/keys/tokens in diff or logs.
  • No v* tag or release commit in this PR.

Notes for reviewer

Contracts and discover resource keys verified against the local upstream OpenAPI document. The task brief says 16 operations; the spec and manifest contain 18 (7 node and 11 credential), all implemented here.

Live APIs were not exercised: integration credentials are absent, so integration tests skip. Live destructive tests require N8N_INTEGRATION_DESTRUCTIVE=1 and never modify existing instance attachments or existing projects.

@SomeoneWithOptions
SomeoneWithOptions merged commit fe6c7c6 into main Oct 22, 2026
5 checks passed
@SomeoneWithOptions
SomeoneWithOptions deleted the feat/policy-documents branch October 22, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant