Repository navigation
feat(policy): add reusable documents and scope attachments - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / why
Expose reusable node and credential type policy documents and scope attachments through the CLI. Add credential instance/project policies so both Preview APIs support the full policy workflow.
Changes
extendsselectors, version checks, attachment uniqueness checks, mutation confirmations, and actionable errors.Verification
make checkpasses locally: formatting, vet, staticcheck, unit tests, race tests, all five cross-builds, tidy check, and vulnerability scan (No vulnerabilities found.).make docsrun after rebasing; generated docs remain current and working tree clean.v*tag or release commit in this PR.Notes for reviewer
Contracts and discover resource keys verified against the local upstream OpenAPI document. The task brief says 16 operations; the spec and manifest contain 18 (7 node and 11 credential), all implemented here.
Live APIs were not exercised: integration credentials are absent, so integration tests skip. Live destructive tests require
N8N_INTEGRATION_DESTRUCTIVE=1and never modify existing instance attachments or existing projects.