Skip to content

SubmitReview: Use Vault token#84

Merged
marco-antognini-sonarsource merged 1 commit intomasterfrom
Pavel/SubmitReviewToken
May 4, 2026
Merged

SubmitReview: Use Vault token#84
marco-antognini-sonarsource merged 1 commit intomasterfrom
Pavel/SubmitReviewToken

Conversation

@pavel-mikula-sonarsource
Copy link
Copy Markdown
Contributor

With the latest automation changes, we need the Vault-based token now. It's the same token as the one in RequestReview.yml file. Please take care of merging this, I have 200+ repos to update.

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Apr 28, 2026

Summary

Migrates the SubmitReview workflow to use Vault-based GitHub token instead of GitHub secrets. This aligns with recent automation changes and matches the token retrieval pattern used in RequestReview.yml. The change removes the now-unnecessary pull-requests: read permission and updates the token source from the GitHub secrets environment to the Vault output.

What reviewers should know

What changed:

  • Vault step now retrieves GITHUB_TOKEN from development/github/token/{REPO_OWNER_NAME_DASH}-jira
  • Token is passed to SubmitReview action via Vault output instead of GitHub secrets
  • Removed pull-requests: read permission (no longer needed)

Review focus:

  • Verify the Vault path format matches your organization's token storage convention
  • Check that {REPO_OWNER_NAME_DASH} is a recognized template variable in the workflow context
  • Confirm this aligns with the RequestReview.yml pattern mentioned in the PR description

Note: This is one of 200+ repos being updated with this pattern, so consistency matters more than innovation here.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

🗣️ Give feedback

@sonarqube-next
Copy link
Copy Markdown

@pavel-mikula-sonarsource pavel-mikula-sonarsource requested a review from a team May 4, 2026 12:10
@marco-antognini-sonarsource marco-antognini-sonarsource merged commit c118799 into master May 4, 2026
7 checks passed
@marco-antognini-sonarsource marco-antognini-sonarsource deleted the Pavel/SubmitReviewToken branch May 4, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants