Repository navigation
fix: relax TestCollector_HeartbeatFile timing for -race on CI - #20
Merged
Merged
Conversation
Each collect() tick calls cpu.Percent + disk/net IOCounters via psutil, which can take 50-100 ms on a loaded runner. The race detector adds further overhead, making the original 400 ms / 100 ms heartbeat budget too tight — the heartbeat ticker never fired before context cancel. New intervals: collect=200 ms, heartbeat=400 ms, context=3 s. This gives ~7 heartbeat opportunities even on a heavily loaded machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: Each
collect()tick invokescpu.Percent+ disk/netIOCountersvia psutil, which takes 50–100 ms per tick on a loaded runner. The race detector adds further scheduling overhead. The original 400 ms context with a 100 ms heartbeat interval left no room for the heartbeat ticker to fire before context cancellation.Fix: Widen the budget to
collect=200ms,heartbeat=400ms,ctx=3s— gives ~7 heartbeat opportunities even under heavy load.