Repository navigation
Collapse the popover's settings into expandable cards - #48
Merged
Merged
Conversation
Polling rate, Lighting, Power Management, Buttons and Profiles become rows in a single grouped card, Control-Center style. Each row shows its current value; the settings rows expand in place one at a time, and the open one is remembered. Battery and DPI stay open at the top. The battery/lighting tips now only appear inside their open section. Scrolling sub-pages get a 560 pt minimum so a short collapsed main page doesn't squeeze them; a half-typed profile name is dropped when its row closes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8Eskh7E8TDXYvX2yS9yZ
- Rows no longer auto-collapse each other; the set of open sections is remembered (popoverExpandedSections). - The hover highlight is an inset rounded shape instead of a full-width band that ran past the inset separators; separators are inset on both sides. - 6 pt between a row and its opened controls, so a highlighted header doesn't sit on top of them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8Eskh7E8TDXYvX2yS9yZ
Polling rate, Lighting, Power Management, Buttons and Profiles each sit in their own card, 10 pt apart like the cards above, instead of one card split by separators, so an open section's controls are clearly bounded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8Eskh7E8TDXYvX2yS9yZ
- Section rows open offline so last-known settings stay readable; only their controls and the Buttons page are disabled. - The sleep timer and Profiles rows keep showing the real value after a failed write, in red, instead of replacing it with an error that could stick for the session. - Buttons says "Needs access" when saved remaps can't fire without Accessibility permission. - Drop a half-typed profile name when the Profiles row disappears. - Share the card surface (cardSurface) between card() and the rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8Eskh7E8TDXYvX2yS9yZ
As a View extension it was main-actor isolated, and card() (a nonisolated free function) couldn't call it: "non-Sendable 'some View'-typed result can not be returned from main actor-isolated instance method". A free function, like card() itself, has no isolation, so both call sites compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SJ8Eskh7E8TDXYvX2yS9yZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal B from the popover design review, the follow-up to #46: the settings below DPI collapse into compact expandable cards, the way Control Center lists its modules. The main page gets much shorter.
What changes
popoverExpandedSectionsin UserDefaults). Buttons still opens its own page.cardSurface()with the other cards, so their style can't drift apart.CHANGELOG.md[Unreleased]anddocs/DOCUMENTATION.md§6.2 are updated, andTests/Scripts/changelog-test.shpasses.Deliberately not in this PR
Testing
Code review
Two review passes found 15 issues in total, and 12 are fixed:
Left as they are:
🤖 Generated with Claude Code
https://claude.ai/code/session_01SJ8Eskh7E8TDXYvX2yS9yZ