Repository navigation
Dark text on the green primary buttons - #50
Merged
Merged
Conversation
The bordered-prominent buttons tinted Razer green drew the system's white label on #44D62C, about 1.9:1 contrast, and macOS gives no way to recolour it. A shared RazerProminentButtonStyle draws the green rounded rect with onRazerGreen text instead, matching the selected chips, with pressed and disabled states and sizing off the control size.
Draw a focus ring for keyboard navigation and the hover wash the app's other custom buttons use. Permissions' Close stays a plain bordered button like its neighbour, and the Send Report spinner draws dark so it shows on the green.
Settings, About, Crash Report's post-send Done and the device test's Start/Run/Next/Done were plain default buttons, so they took the system accent colour (blue) instead of the app's green.
The circle's frame, fill and stroke sat outside the plain button's label, so only the plus glyph was hit-tested. Move them into the label with a circular content shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #49. The bordered-prominent buttons tinted Razer green drew the system's white label on #44D62C, about 1.9:1 contrast. macOS gives no way to recolour that label, so this adds a shared
RazerProminentButtonStylein CardComponents.swift: a green rounded rect withonRazerGreentext, like the selected chips.hoverHighlight) and a focus ring for keyboard navigation.keyboardShortcut(.defaultAction)still works.Applied to Settings Install Now, Permissions Grant… / Relaunch / Done, Crash Report Send, Updated Done, What's New, and the popover's own green buttons (profile Save, Update & Restart / Download, Quit MacRazer). Permissions' not-yet-granted "Close" is now a plain
.borderedbutton, matching the one beside it. The Send Report spinner is drawn dark so it shows on the green.The plain default buttons that took the system accent (blue) are green too: Settings Done, About Done, Crash Report's post-send Done, and the device test's Start / Grant access / Run / Next / Done.
Also fixes the popover's add-profile plus button: only the glyph took clicks, because the circle was drawn outside the button's label. The circle is now part of the label with a circular hit area.
Checked:
swift build,swift test(349 pass), changelog-test.sh. Hosted renders (NSHostingView) of Updated, Crash Report and What's New, plus Settings, About, the device test and Permissions.Not checked: the focus ring, hover and the plus button's hit area in a live window.
🤖 Generated with Claude Code