Updated liquidity_pool Cargo.toml to include emergency_guard dependency#271
Open
aabxtract wants to merge 2 commits into
Open
Updated liquidity_pool Cargo.toml to include emergency_guard dependency#271aabxtract wants to merge 2 commits into
aabxtract wants to merge 2 commits into
Conversation
|
@aabxtract Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a workspace dependency resolution issue by properly registering the newly created
emergency_guardcrate. While the crate was correctly specified as a dependency in theliquidity_poolcontract, it was missing from the root workspace configuration, which prevented proper workspace-level builds and lockfile resolution.Closes #207
Changes Made
"contracts/emergency_guard"to themembersarray in the rootCargo.toml.Why is this needed?
Adding new contracts to the Cargo workspace
membersarray ensures they are included in workspace-wide commands (likecargo check,cargo build, andcargo test). It also ensures they share the unifiedCargo.lockfile, which is required for theliquidity_poolcontract to correctly resolve the localpath = "../emergency_guard"dependency.How to Test
cargo checkat the workspace root to confirm all crates, includingemergency_guardandliquidity_pool, resolve without errors.cargo build -p liquidity_poolto verify the contract compiles successfully with the new dependency.