Issue 318 flash loan repayment validation#367
Open
auracule007 wants to merge 5 commits into
Open
Conversation
|
@auracule007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@EDOHWARES Please review this PR and check workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary #318
Implements flash loan repayment validation for the
flash_loan_vaultcontract.The vault now explicitly checks that, after the receiver callback completes, its token balance is at least the original pre-loan balance plus the required flash loan fee. If the callback fails to repay the borrowed principal plus fee, the contract returns
Error::LoanNotRepaid.Changes
required_balance = pre_balance + feerepayment checkError::LoanNotRepaidwhen repayment is insufficientValidation
cargo fmt --all -- --checkcargo clippy --locked --all-targets --all-features -- -D warningscargo test --lockedNotes
The full test run generated unrelated snapshot updates as a side effect; those were reverted. The PR only modifies the flash loan vault contract and tests.
Closes #318