Update build-installers.yml

[cj-vana]

PR Type

Enhancement

---

Description

• Improved script cleanup mechanism in macOS installer

• Replaced exec with direct command execution

• Added self-cleanup functionality to temp script

---

Diagram Walkthrough

flowchart LR
  A["Original Script"] --> B["Execute Agent"]
  B --> C["Background Cleanup"]
  D["Updated Script"] --> E["Execute Agent"]
  E --> F["Self Cleanup"]
  A -.-> D
  C -.-> F

Loading

File Walkthrough

	Relevant files
Enhancement	build-installers.yml Enhanced script cleanup in macOS installer                              .github/workflows/build-installers.yml Replaced exec with direct command execution for sounddocs-capture-agent Added self-cleanup command rm -f "$0" to temp script Removed background cleanup process with sleep delay Updated comments to reflect new cleanup approach +6/-3

---

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Path Expansion Bug The added command uses a quoted literal "APP_RESOURCES_PATH/sounddocs-capture-agent". Ensure the placeholder replacement via sed applies to this line in the generated temp script and that quoting does not prevent correct path expansion or executable resolution. "APP_RESOURCES_PATH/sounddocs-capture-agent" # Clean up this temp script when the agent exits rm -f "$0" TERM_EOF Exec Removal Behavior Replacing exec with a normal invocation changes signal handling and parent process lifecycle. Validate that Terminal session termination and Ctrl+C behavior still propagate correctly to the agent and that the cleanup runs reliably. "APP_RESOURCES_PATH/sounddocs-capture-agent" # Clean up this temp script when the agent exits rm -f "$0" TERM_EOF Self-Cleanup Robustness Using rm -f "$0" depends on how the temp script is invoked; if $0 is a symlink or if the shell sources the script, removal may fail or be unsafe. Confirm that "$TEMP_SCRIPT" matches $0 and that the file is writable/removable in all install contexts. # Clean up this temp script when the agent exits rm -f "$0" TERM_EOF

[netlify]

✅ Deploy Preview for sounddocsbeta ready!

Name	Link
🔨 Latest commit	cfea141
🔍 Latest deploy log	https://app.netlify.com/projects/sounddocsbeta/deploys/68d169d8e2f8030008cdf177
😎 Deploy Preview	https://deploy-preview-98--sounddocsbeta.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Use a trap for robust cleanup Use trap 'rm -f "$0"' EXIT to ensure the temporary script is always cleaned up upon exit, even in case of errors. This makes the cleanup mechanism more robust. .github/workflows/build-installers.yml [119-130] #!/bin/bash +# Ensure this script cleans itself up on exit +trap 'rm -f "$0"' EXIT + echo "==================================================" echo "📊 Agent status and logs will appear below." echo " Press Ctrl+C to stop the agent." echo "==================================================" echo "" # Run the actual agent executable "APP_RESOURCES_PATH/sounddocs-capture-agent" -# Clean up this temp script when the agent exits -rm -f "$0" - [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential failure case where the temporary script is not cleaned up and proposes using trap, which is a more robust solution for ensuring cleanup.	Medium
More