(Assimp) Syncing fork. #1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,52 @@ | ||||||||||||||||||
| name: Build and Publish Prebuilt Binaries | ||||||||||||||||||
|
|
||||||||||||||||||
| on: | ||||||||||||||||||
| release: | ||||||||||||||||||
| types: [created] | ||||||||||||||||||
|
|
||||||||||||||||||
| jobs: | ||||||||||||||||||
| build: | ||||||||||||||||||
| name: ${{ matrix.name }} | ||||||||||||||||||
| runs-on: ${{ matrix.os }} | ||||||||||||||||||
| strategy: | ||||||||||||||||||
| fail-fast: false | ||||||||||||||||||
| matrix: | ||||||||||||||||||
| include: | ||||||||||||||||||
| - name: windows-x64 | ||||||||||||||||||
| os: windows-latest | ||||||||||||||||||
| arch: x64 | ||||||||||||||||||
| - name: windows-x86 | ||||||||||||||||||
| os: windows-latest | ||||||||||||||||||
| arch: x86 | ||||||||||||||||||
| cmake_args: -A Win32 | ||||||||||||||||||
| - name: macos-x64 | ||||||||||||||||||
| os: macos-13 | ||||||||||||||||||
| - name: macos-arm64 | ||||||||||||||||||
| os: macos-latest | ||||||||||||||||||
| - name: linux-x64 | ||||||||||||||||||
| os: ubuntu-latest | ||||||||||||||||||
|
|
||||||||||||||||||
| steps: | ||||||||||||||||||
| - uses: actions/checkout@v6 | ||||||||||||||||||
|
|
||||||||||||||||||
| - uses: lukka/get-cmake@latest | ||||||||||||||||||
|
|
||||||||||||||||||
| - uses: ilammy/msvc-dev-cmd@v1 | ||||||||||||||||||
| with: | ||||||||||||||||||
| arch: ${{ matrix.arch }} | ||||||||||||||||||
|
|
||||||||||||||||||
|
Comment on lines
+34
to
+37
There was a problem hiding this comment. Gate MSVC dev environment setup to Windows runners The ilammy/msvc-dev-cmd action only works on Windows. As written, this step will run on macOS/Linux and fail. Apply: - - uses: ilammy/msvc-dev-cmd@v1
+ - uses: ilammy/msvc-dev-cmd@v1
+ if: runner.os == 'Windows'
with:
arch: ${{ matrix.arch }}📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.37.1)[error] 37-37: trailing spaces (trailing-spaces) 🤖 Prompt for AI Agents |
||||||||||||||||||
| - name: Build | ||||||||||||||||||
| run: | | ||||||||||||||||||
| cmake -B build -S . ${{ matrix.cmake_args }} -DCMAKE_BUILD_TYPE=Release -DASSIMP_BUILD_TESTS=OFF | ||||||||||||||||||
| cmake --build build --config Release | ||||||||||||||||||
| - uses: TheDoctor0/zip-release@0.7.6 | ||||||||||||||||||
| with: | ||||||||||||||||||
| filename: ${{ matrix.name }}-${{ github.event.release.tag_name }}.zip | ||||||||||||||||||
| directory: build/bin/ | ||||||||||||||||||
|
|
||||||||||||||||||
| - uses: softprops/action-gh-release@v3 | ||||||||||||||||||
| with: | ||||||||||||||||||
| files: build/bin/${{ matrix.name }}-${{ github.event.release.tag_name }}.zip | ||||||||||||||||||
| append_body: true | ||||||||||||||||||
| fail_on_unmatched_files: true | ||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ jobs: | |
| dry-run: false | ||
| language: c++ | ||
| - name: Upload Crash | ||
| uses: actions/upload-artifact@v7 | ||
| if: failure() && steps.build.outcome == 'success' | ||
| with: | ||
| name: artifacts | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,51 @@ | ||||||
| name: Build Windows Installer | ||||||
| on: | ||||||
| push: | ||||||
| branches: [ master ] | ||||||
| pull_request: | ||||||
| branches: [ master ] | ||||||
| jobs: | ||||||
| build: | ||||||
| name: Build the Inno Setup Installer | ||||||
| runs-on: windows-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@v4 | ||||||
| - uses: lukka/get-cmake@latest | ||||||
| - uses: ilammy/msvc-dev-cmd@v1 | ||||||
|
|
||||||
|
|
||||||
| - name: Cache DX SDK | ||||||
| id: dxcache | ||||||
| uses: actions/cache@v4 | ||||||
| with: | ||||||
| path: '${{ github.workspace }}/DX_SDK' | ||||||
| key: ${{ runner.os }}-DX_SDK | ||||||
| restore-keys: | | ||||||
| ${{ runner.os }}-DX_SDK | ||||||
|
|
||||||
| - name: Download DXSetup | ||||||
| run: | | ||||||
| curl -s -o DXSDK_Jun10.exe --location https://download.microsoft.com/download/A/E/7/AE743F1F-632B-4809-87A9-AA1BB3458E31/DXSDK_Jun10.exe | ||||||
| cmd.exe /c start /wait .\DXSDK_Jun10.exe /U /O /F /S /P "${{ github.workspace }}\DX_SDK" | ||||||
|
|
||||||
| - name: Set Windows specific CMake arguments | ||||||
| id: windows_extra_cmake_args | ||||||
| run: echo "::set-output name=args::-DASSIMP_BUILD_ASSIMP_TOOLS=1 -DASSIMP_BUILD_ASSIMP_VIEW=1 -DASSIMP_BUILD_ZLIB=1" | ||||||
|
There was a problem hiding this comment. Replace deprecated set-output command. The -run: echo "::set-output name=args::-DASSIMP_BUILD_ASSIMP_TOOLS=1 -DASSIMP_BUILD_ASSIMP_VIEW=1 -DASSIMP_BUILD_ZLIB=1"
+run: echo "args=-DASSIMP_BUILD_ASSIMP_TOOLS=1 -DASSIMP_BUILD_ASSIMP_VIEW=1 -DASSIMP_BUILD_ZLIB=1" >> $GITHUB_OUTPUT📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| - name: configure and build | ||||||
| uses: lukka/run-cmake@v3 | ||||||
| env: | ||||||
| DXSDK_DIR: '${{ github.workspace }}/DX_SDK' | ||||||
|
|
||||||
| with: | ||||||
| cmakeListsOrSettingsJson: CMakeListsTxtAdvanced | ||||||
| cmakeListsTxtPath: '${{ github.workspace }}/CMakeLists.txt' | ||||||
| cmakeAppendedArgs: '-GNinja -DCMAKE_BUILD_TYPE=Release ${{ steps.windows_extra_cmake_args.outputs.args }} ${{ steps.hunter_extra_cmake_args.outputs.args }}' | ||||||
| buildWithCMakeArgs: '--parallel 24 -v' | ||||||
| buildDirectory: '${{ github.workspace }}/build/' | ||||||
|
|
||||||
| - name: Compile .ISS to .EXE Installer | ||||||
| uses: Minionguyjpro/Inno-Setup-Action@v1.2.5 | ||||||
| with: | ||||||
| path: packaging/windows-innosetup/script_x64.iss | ||||||
| options: /O+ | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |||||
| name: adress-sanitizer | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
| - uses: lukka/get-cmake@latest | ||||||
| - uses: lukka/set-shell-env@v1 | ||||||
| with: | ||||||
|
|
@@ -38,15 +38,15 @@ jobs: | |||||
| name: undefined-behavior-sanitizer | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
| - uses: lukka/get-cmake@latest | ||||||
|
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainTrailing spaces flagged by yamllint YAMLlint reports trailing spaces on Line 42 and Line 47. Trim them to appease linters. Apply: - - uses: lukka/get-cmake@latest
+ - uses: lukka/get-cmake@latest
- - uses: lukka/set-shell-env@v1
+ - uses: lukka/set-shell-env@v1Run to verify: Also applies to: 47-47 🏁 Script executed: #!/bin/bash
# Show the exact lines with trailing spaces for confirmation
nl -ba .github/workflows/sanitizer.yml | sed -n '38,52p'
# Simple grep for trailing spaces
grep -nE ' +$' .github/workflows/sanitizer.yml || echo "No trailing spaces found."Length of output: 322 Trim trailing spaces in sanitizer.yml YAMLlint reports trailing spaces on multiple lines in • Lines with content:
Example diff: - - uses: lukka/get-cmake@latest
+ - uses: lukka/get-cmake@latest
- - uses: lukka/set-shell-env@v1
+ - uses: lukka/set-shell-env@v1Apply the same trimming to any other lines (including blank ones) flagged by 📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.37.1)[error] 42-42: trailing spaces (trailing-spaces) 🤖 Prompt for AI Agents |
||||||
| - uses: lukka/set-shell-env@v1 | ||||||
| with: | ||||||
| CXX: clang++ | ||||||
| CC: clang | ||||||
|
|
||||||
| - name: configure and build | ||||||
| uses: lukka/run-cmake@v3 | ||||||
| with: | ||||||
| cmakeListsOrSettingsJson: CMakeListsTxtAdvanced | ||||||
| cmakeListsTxtPath: '${{ github.workspace }}/CMakeLists.txt' | ||||||
|
|
@@ -62,7 +62,7 @@ jobs: | |||||
| name: printf-sanitizer | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - uses: actions/checkout@v6 | ||||||
|
|
||||||
| - name: run scan_printf script | ||||||
| run: ./scripts/scan_printf.sh | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,3 +120,9 @@ tools/assimp_qt_viewer/ui_mainwindow.h | |
|
|
||
| #Generated directory | ||
| generated/* | ||
|
|
||
| # 3rd party cloned repos/tarballs etc | ||
| # meshlab repo, automatically cloned via CMake (to gain 2 source files for VRML file format conversion) | ||
| contrib/meshlab/autoclone | ||
| # tinyusdz repo, automatically cloned via CMake | ||
| contrib/tinyusdz/autoclone | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hunter Windows matrix entry missing toolchain; inconsistent naming
Also align all conditionals that check matrix.name accordingly.
📝 Committable suggestion
🤖 Prompt for AI Agents