Skip to content

Reject mixed-variant VecValue in TryFrom #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbower merged 1 commit into from
Aug 19, 2026
Merged

Reject mixed-variant VecValue in TryFrom #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/enums/value/conversions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,26 @@ impl From<BooleanArrayV> for Value {

// TryFrom for Array-like Types

// Checks that VecValue is a single type that can actually be consolidated
fn vecvalue_single_variant(values: &[Value], to: &'static str) -> Result<(), MinarrowError> {
let Some(first) = values.first() else {
return Ok(());
};
let head = std::mem::discriminant(first);
if let Some(mixed) = values[1..].iter().find(|v| std::mem::discriminant(*v) != head) {
return Err(MinarrowError::TypeError {
from: "Value::VecValue",
to,
message: Some(format!(
"VecValue mixes different types {} and {}. A heterogeneous VecValue cannot coerce to {to}",
value_variant_name(first),
value_variant_name(mixed)
)),
});
}
Ok(())
}

impl TryFrom<Value> for Array {
type Error = MinarrowError;
fn try_from(v: Value) -> Result<Self, Self::Error> {
Expand Down Expand Up @@ -1064,6 +1084,7 @@ impl TryFrom<Value> for Array {
Value::Cube(_) => Array::try_from(Table::try_from(v)?),
Value::VecValue(inner) => {
let values = Arc::try_unwrap(inner).unwrap_or_else(|arc| (*arc).clone());
vecvalue_single_variant(&values, "Array")?;
let pieces: Result<Vec<Array>, _> =
values.into_iter().map(Array::try_from).collect();
Array::try_from(pieces?)
Expand Down Expand Up @@ -1350,6 +1371,7 @@ impl TryFrom<Value> for Table {
// layer rejoins.
Value::VecValue(inner) => {
let values = Arc::try_unwrap(inner).unwrap_or_else(|arc| (*arc).clone());
vecvalue_single_variant(&values, "Table")?;
let pieces: Result<Vec<Table>, _> =
values.into_iter().map(Table::try_from).collect();
Table::try_from(pieces?)
Expand Down Expand Up @@ -1440,6 +1462,7 @@ impl TryFrom<Value> for SuperTable {
)),
Value::VecValue(inner) => {
let values = Arc::try_unwrap(inner).unwrap_or_else(|arc| (*arc).clone());
vecvalue_single_variant(&values, "SuperTable")?;
let pieces: Result<Vec<Table>, _> =
values.into_iter().map(Table::try_from).collect();
Ok(SuperTable::from(pieces?))
Expand Down Expand Up @@ -1493,6 +1516,7 @@ impl TryFrom<Value> for SuperArray {
}
Value::VecValue(inner) => {
let values = Arc::try_unwrap(inner).unwrap_or_else(|arc| (*arc).clone());
vecvalue_single_variant(&values, "SuperArray")?;
let pieces: Result<Vec<Array>, _> =
values.into_iter().map(Array::try_from).collect();
Ok(SuperArray::from(pieces?))
Expand Down Expand Up @@ -2464,9 +2488,6 @@ mod accessor_tests {
}
}

// VecValue -> typed-T terminal coercion tests. Exercises the engine wire format
// produced by `Long` fan-out gather (`Value::VecValue<Vec<Value>>`) flowing into
// `BlockStack<T>::collect()`'s `T::try_from(value)` step.
#[cfg(test)]
mod vecvalue_terminal_coercion_tests {
use super::*;
Expand Down
Loading