Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untangle VGA from sala/depthmapX/cli and move functionality to a module. More specifically the move is of the "Run Visibility Graph Analysis..." menu item and related dialog (renamed from OptionsDlg to VGAOptionsDlg). This dialog contains the all-cell analyses Isovist (Calculates isovist properties from each cell), Local and Global Visibility, Metric and Angular mean depths, and Through-vision. The move also includes the three "Depth" menu items (Visual, Angular Metric) which calculate the respective depth from a cell, but also cli and regression tests (there are no VGA core tests).
If there is agreement with the spirit of this change I will also convert the other analyses (axial, segment, agents) as modules.
For the most straightforward comparison only refer to changes of the first commit, as the second commit auto-formats code.